Bug 11945 - XML files lack Romanian variants
Summary: XML files lack Romanian variants
Status: CLOSED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: All All
: medium major
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
: 11944 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-08-11 03:14 UTC by dumol
Modified: 2007-08-19 05:48 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Adds the two missing variants to the Romanian section of the base.xml.in file (967 bytes, patch)
2007-08-11 03:16 UTC, dumol
Details | Splinter Review

Description dumol 2007-08-11 03:14:47 UTC
The Romanian xkeyboard-config layout has five variants (including "basic") but two of them ("comma" and "academic") are not exposed in the base.xml.in file making them impossible to set using the graphical tool in GNOME. As this has just become an important issue now with the new Romanian legislation that enforces the use of "commabelow" diacritics in public offices I took the liberty of setting the importance of this bug to "major".

I haven't realized the importance of the base.xml.in file, so this has eluded me for a long time. Now I'm also wondering if it would be appropriate to list the QWERTY variants of the Romanian layout in the sun.xml.in file too... For the moment there is no Romanian layout/variants listed in the sun.xml.in file. Please advise.

Will shortly attach a patch for the CVS version that fixes the problem in the base.xml.in file. Please review and commit if appropriate. Thank you!
Comment 1 dumol 2007-08-11 03:16:14 UTC
Created attachment 11089 [details] [review]
Adds the two missing variants to the Romanian section of the base.xml.in file
Comment 2 Sergey V. Udaltsov 2007-08-11 16:51:00 UTC
Thanks, updated. Well spotted.
Comment 3 Sergey V. Udaltsov 2007-08-11 16:56:51 UTC
*** Bug 11944 has been marked as a duplicate of this bug. ***
Comment 4 dumol 2007-08-12 14:27:08 UTC
Thank you Sergey. Credits for spotting this go to Eddy Petrişor (http://bugs.debian.org/436993) and Jani Monoses (https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/108057/comments/44), I'm not a user of the GNOME layout selection tool, so I've never bumped into it.

Before closing this bug for good, what do you think about the lack of any Romanian layout/variant in the sun.xml.in file? I suppose the file is used for Sun keyboards and all the QWERTY variants from the RO layout should be listed there, but I'm not sure about it. Should I create a patch for the sun.xml.in file too?
Comment 5 Sergey V. Udaltsov 2007-08-12 14:40:32 UTC
> Before closing this bug for good, what do you think about the lack of any
> Romanian layout/variant in the sun.xml.in file? I suppose the file is used for
> Sun keyboards and all the QWERTY variants from the RO layout should be listed
> there, but I'm not sure about it. Should I create a patch for the sun.xml.in
> file too?
Honestly, I do not think at all about sun.xml. This file (along with sun ruleset) is not actively maintained (unless Sun people send patches). So I consider this stuff as kind of "contrib" data which I do not care too much about. Feel free to send patches if you feel you really ought to.

Comment 6 Alan Coopersmith 2007-08-15 11:33:46 UTC
This Sun person has no plans to send patches for the Sun rules or xml file,
because we don't use them - we use the Xorg/base rules with Xorg in Solaris.
Comment 7 dumol 2007-08-19 05:48:07 UTC
(In reply to comment #6)
> This Sun person has no plans to send patches for the Sun rules or xml file,
> because we don't use them - we use the Xorg/base rules with Xorg in Solaris.

Well, that means there's no need to patch the sun.xml.in file, so I'm closing this bug. Thank you all. 



Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.