Bug 12053 - move generic xv clipping helper to server
Summary: move generic xv clipping helper to server
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: xorg-7.3
  Show dependency tree / graph
 
Reported: 2007-08-18 08:42 UTC by Alex Deucher
Modified: 2007-08-31 13:29 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch to add to server (4.06 KB, patch)
2007-08-18 08:43 UTC, Alex Deucher 		no flags Details | Splinter Review
add _X_EXPORT to exported functions from hw/modes/xfree86/modes (18.53 KB, patch)
2007-08-21 16:48 UTC, Alex Deucher 		no flags Details | Splinter Review
View All

Description Alex Deucher 2007-08-18 08:42:06 UTC 
fix up and move the intel crtc xv clipping helper to the server.  It's generic enough to be used by any driver.  Works fine on radeon.  Other drivers may find it useful.
Comment 1 Alex Deucher 2007-08-18 08:43:55 UTC 
Created attachment 11171 [details] [review]
patch to add to server

fix and add the crtc xv clipping code to the server.
Comment 2 Alex Deucher 2007-08-18 08:44:36 UTC 
It'd be nice to get this in for 7.3 so drivers can start to move to the generic code after 7.3 is released.
Comment 3 Eric Anholt 2007-08-20 17:56:29 UTC 
<anholt> ajax/daniels: you guys fine with #12053 going in?  since its pure api addition, and has been used in 2 drivers, I'm inclined to OK it.
<ajax> anholt: all API additions should be marked with _X_EXPORT and listed in hw/xfree86/loader/*sym.c
<ajax> but, other than that, sure, looks fine.
Comment 4 Alex Deucher 2007-08-20 21:41:42 UTC 
I've pushed this to master:
1f6ddae003ec65d6bc567831bf32bf75dfefdd6c
53c04351c462d2ae307684e50d5960debe1ee557

FWIW, none of the other functions exported from hw/xfree86/modes are marked with _X_EXPORT except xf86CVTMode().  Should we add _X_EXPORT to all of them?
Comment 5 Alex Deucher 2007-08-21 16:48:00 UTC 
Created attachment 11200 [details] [review]
add _X_EXPORT to exported functions from hw/modes/xfree86/modes

add _X_EXPORT to exported functions from hw/modes/xfree86/modes and add a few missing functions to xf86sym.c
Comment 6 Alex Deucher 2007-08-22 16:27:30 UTC 
committed _X_EXPORT d0dc9698ae4324d44ed4c0482d6858d0b73bff33
Comment 7 Eric Anholt 2007-08-31 13:29:00 UTC 
Both pieces are merged to server-1.4-branch.  Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.