Bug 1207 - Build breaks on xc/lib/GL/glx/Imakefile
Summary: Build breaks on xc/lib/GL/glx/Imakefile
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/Ext/GLX (show other bugs)
Version: git
Hardware: SPARC Solaris
: highest blocker
Assignee: Alan Coopersmith
QA Contact:
Depends on:
Blocks: 351
  Show dependency treegraph
Reported: 2004-08-27 10:11 UTC by Alan Coopersmith
Modified: 2004-08-26 17:25 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Patch to move line break (447 bytes, patch)
2004-08-27 10:13 UTC, Alan Coopersmith
no flags Details | Splinter Review

Description Alan Coopersmith 2004-08-27 10:11:37 UTC
making Makefiles in lib/GL/glx...
"./Imakefile", line 145:  (in preprocessor if): syntax error
../../../config/imake/imake: Exit code 2.

The offending lines are:
    144 #if defined(DarwinArchitecture) || defined(OS2Architecture) || defined(L
   144 ynxOSA\
    145 rchitecture)

Putting a line break/continuation in the middle of a preprocessor symbol is 
a bad idea - will apply patch to fix this.

This is why the Solaris tinderbox is currently flaming.
Comment 1 Alan Coopersmith 2004-08-27 10:13:14 UTC
Created attachment 745 [details] [review]
Patch to move line break
Comment 2 Alan Coopersmith 2004-08-27 10:25:22 UTC
Log message:
  2004-08-27  Alan Coopersmith  <alan.coopersmith@sun.com>
  	* lib/GL/glx/Imakefile:
  	Move line break/continuation to not be in the middle of a word
  	(Bugzilla #1207)

Modified files:
  Revision      Changes    Path
  1.324         +7 -1      xc/ChangeLog
  1.9           +3 -3      xc/lib/GL/glx/Imakefile

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.