Bug 12097 - NULL pointer dereference in viaXMesaWindowMoved
Summary: NULL pointer dereference in viaXMesaWindowMoved
Status: RESOLVED WONTFIX
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/Unichrome (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-22 06:49 UTC by Olivier Blin
Modified: 2012-07-14 20:02 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
fix NULL pointer dereference in viaXMesaWindowMoved (573 bytes, patch)
2007-08-22 06:50 UTC, Olivier Blin
Details | Splinter Review

Description Olivier Blin 2007-08-22 06:49:41 UTC
With unichrome dri, glxinfo segfaults with the following stack trace:

0xb778766e in viaXMesaWindowMoved (vmesa=0x8056220) at via_context.c:745
745        switch (vmesa->glCtx->DrawBuffer->_ColorDrawBufferMask[0]) {
(gdb) bt
#0  0xb778766e in viaXMesaWindowMoved (vmesa=0x8056220) at via_context.c:745
#1  0xb7787a6b in viaGetLock (vmesa=0x8056220, flags=0) at via_context.c:913
#2  0xb778bd09 in viaWaitIdle (vmesa=0x8056220, light=0 '\0') at via_ioctl.c:455
#3  0xb7787efd in viaDestroyContext (driContextPriv=0x80540e8) at via_context.c:701
#4  0xb7783837 in driDestroyContext (dpy=0x804e008, scrn=0, contextPrivate=0x80540e8) at ../common/dri_util.c:753
#5  0xb7dfbeea in DestroyContext (dpy=0x804e008, gc=0x80560e0) at glxcmds.c:472
#6  0x0804a0ae in main (argc=-1074695228, argv=0x0) at glxinfo.c:495
#7  0xb7c95f90 in __libc_start_main () from /lib/i686/libc.so.6
#8  0x08048bc1 in _start ()

vmesa->glCtx->DrawBuffer is NULL in viaXMesaWindowMoved()
Comment 1 Olivier Blin 2007-08-22 06:50:58 UTC
Created attachment 11207 [details] [review]
fix NULL pointer dereference in viaXMesaWindowMoved

The attached patch fixes the glxinfo segfault, but I'm not sure it's the correct way to proceed.
Comment 2 Gabriel Mansi 2007-08-22 09:55:32 UTC
I think that if nothing was sent to the hardware there is no reason to wait for idle in viaDestroyContext but let me check if that is the case. There is a similar problem when driDrawable is NULL.
Comment 3 Colin Guthrie 2009-04-29 05:11:49 UTC
This is a pretty old bug now, but we do still carry it on our Mesa packages... Is there any chance it can be committed upstream. Are there more appropriate QA contacts at mesa these days?
Comment 4 Olivier Blin 2012-07-14 20:02:52 UTC
Closing as wontfix, since unichrome (DRI1) has been dropped.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.