Bug 1238 - Keycodes for PrintScreen and SysRq
Summary: Keycodes for PrintScreen and SysRq
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Input/Keyboard (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 351
  Show dependency treegraph
 
Reported: 2004-08-30 12:56 UTC by Owen Taylor
Modified: 2004-08-30 12:25 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Fix for differing keycodes for Print and SysReq (938 bytes, patch)
2004-08-30 13:59 UTC, Kristian Høgsberg
no flags Details | Splinter Review

Description Owen Taylor 2004-08-30 12:56:22 UTC
PrintScreen and SysRequest==Alt+PrintScreen should give the same
keycode since they are the same physical key. This was fixed about
a year ago with the following code in xf86PostKbdEvent():

  if (scanCode == KEY_SysReqest)
    scanCode = KEY_Print;
  else if (scanCode == KEY_Break)
    scanCode = KEY_Pause;

And the shippe XKB files expect this to be the case. But now the
keys are reporting different keycodes again, so the above code
is not getting run or not working as expected.
Comment 1 Kristian Høgsberg 2004-08-30 13:59:54 UTC
Created attachment 778 [details] [review]
Fix for differing keycodes for Print and SysReq

The patch was taken from the old keyboard driver, were it's been in use for at
least one release.  It's a low risk patch that fixes a keyboard driver
regression.
Comment 2 Kristian Høgsberg 2004-08-30 14:01:01 UTC
Adding as blocker since it's a regression and has a simple fix.
Comment 3 Kevin E. Martin 2004-08-30 18:36:23 UTC
Patch checked in.
Closing.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.