Bug 12429 - audit changes
Summary: audit changes
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Havoc Pennington
QA Contact: John (J5) Palmieri
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-14 15:02 UTC by Matthias Clasen
Modified: 2007-10-03 14:30 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
dbus-1.1.2-audit-user.patch (1.51 KB, patch)
2007-09-14 15:04 UTC, Matthias Clasen 		Details | Splinter Review
View All

Description Matthias Clasen 2007-09-14 15:02:21 UTC 
Here is a patch which Dan Walsh put into the Fedora dbus packages recently,
with the following ChangeLog:

Reverse we_were_root check to setpcap if we were root.  Also only init
audit if we were root.  So error dbus message will not show up when policy
reload happens.  dbus -session will no longer try to send audit message,
only system will.

While I haven't looked at the patch in great depth, the explanation makes
sense to me.
Comment 1 Matthias Clasen 2007-09-14 15:04:20 UTC 
Created attachment 11577 [details] [review]
dbus-1.1.2-audit-user.patch
Comment 2 Havoc Pennington 2007-09-14 15:12:43 UTC 
Sounds fine, I don't know anything about this code though so I can't say I looked too closely.
Comment 3 John (J5) Palmieri 2007-10-03 14:30:48 UTC 
pushed to git

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.