This crash would happen if NULL was passed as the pending_return argument and the connection was disconnected. I'll attach a patch.
Created attachment 11897 [details] [review] proposed patch
Shouldn't it add an "if (pending_return)" instead of removing the assignment? (Was it already assigned to earlier in the code?)
(In reply to comment #2) > Shouldn't it add an "if (pending_return)" instead of removing the assignment? > (Was it already assigned to earlier in the code?) There is already a NULL assignment before that: if (pending_return) *pending_return = NULL; CONNECTION_LOCK (connection); if (!_dbus_connection_get_is_connected_unlocked (connection)) { CONNECTION_UNLOCK (connection); *pending_return = NULL; return TRUE; }
committed, thanks
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.