Bug 1299 - RFE: Rework PS DDX to support non-TrueColor/non-PseudoColor visuals
Summary: RFE: Rework PS DDX to support non-TrueColor/non-PseudoColor visuals
Status: RESOLVED FIXED
Alias: None
Product: xprint
Classification: Unclassified
Component: Server: DDX: PostScript (show other bugs)
Version: unspecified
Hardware: All All
: high enhancement
Assignee: Roland Mainz
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 1522 2879
  Show dependency treegraph
 
Reported: 2004-09-06 19:15 UTC by Roland Mainz
Modified: 2004-12-12 02:02 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Prototype patch for 2004-09-06-trunk (43.05 KB, patch)
2004-09-07 00:13 UTC, Roland Mainz
no flags Details | Splinter Review
Updated prototype patch for 2004-09-06-trunk (48.04 KB, patch)
2004-09-07 03:14 UTC, Roland Mainz
no flags Details | Splinter Review
New snapshot for 2004-09-20-trunk (54.44 KB, patch)
2004-09-20 14:08 UTC, Roland Mainz
no flags Details | Splinter Review
[FIXED_X11R68x] New patch for 2004-10-04-trunk (58.44 KB, patch)
2004-10-03 22:02 UTC, Roland Mainz
roland.mainz: 6.8-branch+
Details | Splinter Review

Description Roland Mainz 2004-09-06 19:15:38 UTC
RFE: Rework PS DDX to support non-TrueColor/non-PseudoColor visuals.

Right now the PostScript DDX only supports one 8bit PseudoColor and one 24bit
TrueColor visual while there are requests to support more visuals with higher
color precision (for example there is urgend need for a 10bit GreyScale visual
for medical applications) ...
Comment 1 Roland Mainz 2004-09-07 00:13:16 UTC
Created attachment 833 [details] [review]
Prototype patch for 2004-09-06-trunk
Comment 2 Roland Mainz 2004-09-07 03:14:02 UTC
Created attachment 834 [details] [review]
Updated prototype patch for 2004-09-06-trunk

The new patch fixes a couple of minor nits.

The 12bit GrayScale codepath is still untested due lack of a simple test
client... ;-(
Comment 3 Roland Mainz 2004-09-20 14:08:24 UTC
Created attachment 950 [details] [review]
New snapshot for 2004-09-20-trunk

Changes:
- Added framework for turning visuals on/off via commandline options
- Added TrueColor visual with 10bit per R,G,B-gun
- Added 8bit GrayScale visual

ToDo items:
- Need support to render images with more than 24bit (8bit per R,G,B-gun) in
PsArea.c (for both the new 30bit TrueColor and the 12bit GrayScale visual)
- Need commandline parser to turn new visuals on/off and a way to select the
default visual
- 1bit StaticGray visual
Comment 4 Roland Mainz 2004-10-03 22:02:32 UTC
Created attachment 1001 [details] [review]
[FIXED_X11R68x] New patch for 2004-10-04-trunk

Note:
The CPP symbol |PSOUT_USE_DEEPCOLOR| is currently not set as there is no
support for 36bit Postscript images yet. I filed bug 1522 ("RFE: Postscript DDX
needs support for 36bit deep images") for that.
Comment 5 Roland Mainz 2004-10-03 22:05:56 UTC
Patch (attachment 1001 [details] [review]) checked-in...

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.425; previous revision: 1.424
/cvs/xorg/xc/programs/Xserver/Xprint/Init.c,v  <--  Init.c
new revision: 1.8; previous revision: 1.7
/cvs/xorg/xc/programs/Xserver/Xprint/ps/Ps.h,v  <--  Ps.h
new revision: 1.4; previous revision: 1.3
/cvs/xorg/xc/programs/Xserver/Xprint/ps/PsArea.c,v  <--  PsArea.c
new revision: 1.3; previous revision: 1.2
/cvs/xorg/xc/programs/Xserver/Xprint/ps/PsColor.c,v  <--  PsColor.c
new revision: 1.4; previous revision: 1.3
/cvs/xorg/xc/programs/Xserver/Xprint/ps/PsInit.c,v  <--  PsInit.c
new revision: 1.5; previous revision: 1.4
/cvs/xorg/xc/programs/Xserver/Xprint/ps/psout.c,v  <--  psout.c
new revision: 1.4; previous revision: 1.3
/cvs/xorg/xc/programs/Xserver/Xprint/ps/psout.h,v  <--  psout.h
new revision: 1.3; previous revision: 1.2
Mailing the commit message to xorg-commit@pdx.freedesktop.org...

... marking bug as FIXED.

Followup is bug 1522 ("RFE: Postscript DDX needs support for 36bit deep images")
to get the support for 36bit images in PsArea.c and psout.c
Comment 6 Julien Lafon 2004-11-09 01:52:02 UTC
Comment on attachment 1001 [details] [review]
[FIXED_X11R68x] New patch for 2004-10-04-trunk

nominating for X11R6.8.2 as needed by the Qt library and KDE.
Comment 7 Roland Mainz 2004-11-19 07:35:26 UTC
Comment on attachment 1001 [details] [review]
[FIXED_X11R68x] New patch for 2004-10-04-trunk

Approved for the X11R6.8.x branch in the 2004-11-17 release-wranglers phone
call.
Please don't commit it yourself, I'll handle that once the CVS service is
available again.
Comment 8 Roland Mainz 2004-12-12 21:02:06 UTC
Comment on attachment 1001 [details] [review]
[FIXED_X11R68x] New patch for 2004-10-04-trunk

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.39; previous revision: 1.365.2.38
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/Xprint/Init.c,v  <--  Init.c
new revision: 1.6.4.1; previous revision: 1.6
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/Xprint/ps/Ps.h,v	<--  Ps.h
new revision: 1.3.4.1; previous revision: 1.3
/cvs/xorg/xc/programs/Xserver/Xprint/ps/PsArea.c,v  <--  PsArea.c
new revision: 1.2.4.1; previous revision: 1.2
/cvs/xorg/xc/programs/Xserver/Xprint/ps/PsColor.c,v  <--  PsColor.c
new revision: 1.3.4.1; previous revision: 1.3
/cvs/xorg/xc/programs/Xserver/Xprint/ps/PsInit.c,v  <--  PsInit.c
new revision: 1.3.4.1; previous revision: 1.3
/cvs/xorg/xc/programs/Xserver/Xprint/ps/psout.c,v  <--	psout.c
new revision: 1.3.4.1; previous revision: 1.3
/cvs/xorg/xc/programs/Xserver/Xprint/ps/psout.h,v  <--	psout.h
new revision: 1.2.4.1; previous revision: 1.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.