Bug 13101 - xorg-server has a typo in hw/xfree86/os-support/bsd/i386_video.c
Summary: xorg-server has a typo in hw/xfree86/os-support/bsd/i386_video.c
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 7.3 (2007.09)
Hardware: x86-64 (AMD64) FreeBSD
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL: http://www.cokane.org/dokuwiki/techhe...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2007-11-05 11:00 UTC by Coleman Kane
Modified: 2008-01-29 09:48 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Diff to hw/xfree86/os-support/bsd/i386_video.c to fix breakage (387 bytes, patch)
2007-11-05 11:02 UTC, Coleman Kane
no flags Details | Splinter Review

Description Coleman Kane 2007-11-05 11:00:40 UTC
There is a typo in i386_video.c that breaks the build if I passed --enable-debug to configure. It is a simple fix and the software builds after it is applied.

At line 606 of hw/xfree86/os-support/bsd/i386_video.c, the variable "mrd" was accidentally typed as "rd" (leaving the 'm' off of its name). There is no variable 'rd' declared, so the compiler chokes.

This probably applies to i386 as well as amd64, but I am only using the latter.
Comment 1 Coleman Kane 2007-11-05 11:02:33 UTC
Created attachment 12360 [details] [review]
Diff to hw/xfree86/os-support/bsd/i386_video.c to fix breakage

You must apply this patch within the hw/xfree86/os-support/bsd directory of the xorg-server distribution. I inspected the current xorg-server head on gitweb today and the problem appears to be present.
Comment 2 Alan Coopersmith 2008-01-29 09:48:35 UTC
Patch committed to git master - thanks for submitting it.

commit df325be394e1f75c396b2768f81373f2989aef7c
Author: Coleman Kane <cokane@cokane.org>
Date:   Tue Jan 29 09:47:00 2008 -0800

    Bug 13101: xorg-server has a typo in hw/xfree86/os-support/bsd/i386_video.c



Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.