Bug 13165 - poor TV out geometry
Summary: poor TV out geometry
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: git
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Zou Nan hai
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-09 20:24 UTC by Robert Lowery
Modified: 2008-01-01 19:03 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Robert Lowery 2007-11-09 20:24:07 UTC
The TV out geometry of the intel driver is poor for the modes I use (PAL and 576p), although I suspect this is a general problem across all modes.

The issues include not filling the screen (black bar at the bottom) and curved output that is not square on the screen.  The patch below appears to help 576p somewhat, but is not a compete solution.  Note the 576p refresh rate should be 50Hz.  The windows driver works fine.

Could someone with either access to the intel doco or the windows driver source code please look into this?

--- a/src/i830_tv.c
+++ b/src/i830_tv.c
@@ -580,12 +584,12 @@ const static tv_mode_t tv_modes[] = {
     {
        .name       = "576p",
        .clock  = 107520,       
-       .refresh        = 59.94,
+       .refresh        = 50.0,
        .oversample     = TV_OVERSAMPLE_4X,
        .component_only = 1,
 
-       .hsync_end      = 64,               .hblank_end         = 139,
-       .hblank_start   = 859,              .htotal             = 863,
+       .hsync_end      = 64,               .hblank_end         = 132,
+       .hblank_start   = 852,              .htotal             = 863,
 
        .progressive    = TRUE,         .trilevel_sync = FALSE,
Comment 1 Robert Lowery 2007-12-22 01:29:41 UTC
(In reply to comment #0)
> The TV out geometry of the intel driver is poor for the modes I use (PAL and
> 576p), although I suspect this is a general problem across all modes.
> 
> The issues include not filling the screen (black bar at the bottom) and curved
> output that is not square on the screen.  The patch below appears to help 576p
> somewhat, but is not a compete solution.  Note the 576p refresh rate should be
> 50Hz.  The windows driver works fine.
> 
> Could someone with either access to the intel doco or the windows driver source
> code please look into this?
> 
> --- a/src/i830_tv.c
> +++ b/src/i830_tv.c
> @@ -580,12 +584,12 @@ const static tv_mode_t tv_modes[] = {
>      {
>         .name       = "576p",
>         .clock  = 107520,       
> -       .refresh        = 59.94,
> +       .refresh        = 50.0,
>         .oversample     = TV_OVERSAMPLE_4X,
>         .component_only = 1,
> 
> -       .hsync_end      = 64,               .hblank_end         = 139,
> -       .hblank_start   = 859,              .htotal             = 863,
> +       .hsync_end      = 64,               .hblank_end         = 132,
> +       .hblank_start   = 852,              .htotal             = 863,
> 
>         .progressive    = TRUE,         .trilevel_sync = FALSE,
> 

It turns out I can fix my geometry problems using xrandr margin adjustments (LEFT, BOTTOM, RIGHT, TOP).

I still believe the above is an appropriate patch to improve output of 576p given it is 50hz format
Comment 2 Zou Nan hai 2008-01-01 19:03:33 UTC
you are right, fixed 


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.