Bug 13201 - rarian: missing expression on return statement
Summary: rarian: missing expression on return statement
Status: RESOLVED FIXED
Alias: None
Product: Rarian
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium normal
Assignee: Don Scorgie
QA Contact: Mauro Parra-Miranda
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-12 11:01 UTC by Mauro Parra-Miranda
Modified: 2008-01-07 13:49 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Mauro Parra-Miranda 2007-11-12 11:01:38 UTC
From [1]:

I just tried to compile package rarian-0.6.0-8

The compiler said

rarian-reg-utils.c:819: warning: 'return' with no value, in function returning
non-void

The source code is

                return;

Usually, I'd suggest add expression to return statement, but for
this code, I'd suggest changing the return type of the function
to void.

[1] https://bugzilla.novell.com/show_bug.cgi?id=340620
Comment 1 Daniel Macks 2007-11-14 11:09:12 UTC
Could you give more context to that line of code (what function is it)? I don't see a "return;" line anywhere near line 819 in rarian-reg-utils.c from the original rarian-0.6.0 source.
Comment 2 Don Scorgie 2007-11-14 11:23:07 UTC
Error is in:
process_section_path
(search for the fprintf to stderr).  The function should be returning void anyway.
Comment 3 Don Scorgie 2008-01-07 13:49:55 UTC
I've apparently fixed this a while ago.  Wonder why I didn't mention it?

2007-11-14  Don Scorgie  <Don@Scorgie.org>

	* librarian/rarian-reg-utils.c:
	* librarian/rarian-reg-full.c:
	* librarian/rarian-reg-utils.h:
	* librarian/rarian-reg-full.h:
	Make process_section_path return void
	(fixes compiler warning - bug #13201)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.