Bug 13306 - Display brightness automatically adjusts to maxmim
Summary: Display brightness automatically adjusts to maxmim
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Jesse Barnes
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 13493
  Show dependency treegraph
 
Reported: 2007-11-19 15:31 UTC by Orion Poplawski
Modified: 2007-12-07 10:05 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
X log (58.84 KB, text/plain)
2007-11-19 15:32 UTC, Orion Poplawski
no flags Details
xorg.conf (1.33 KB, application/octet-stream)
2007-11-19 15:32 UTC, Orion Poplawski
no flags Details
latest backlight fixes (1.63 KB, text/x-diff)
2007-12-04 17:09 UTC, Jesse Barnes
no flags Details
backlight fixes (1.22 KB, text/x-diff)
2007-12-04 18:40 UTC, Jesse Barnes
no flags Details

Description Orion Poplawski 2007-11-19 15:31:22 UTC
Moving from Fedora 5 to 7 on a Dell Latitude D610 with Intel 915GM we see the brightness automatically increase to maximum quickly after any attempt to dim the display.  Kills battery life.

(II) Module intel: vendor="X.Org Foundation"
        compiled for 1.3.0, module version = 2.1.1
        Module class: X.Org Video Driver
        ABI class: X.Org Video Driver, version 1.2
Comment 1 Orion Poplawski 2007-11-19 15:32:18 UTC
Created attachment 12632 [details]
X log
Comment 2 Orion Poplawski 2007-11-19 15:32:39 UTC
Created attachment 12633 [details]
xorg.conf
Comment 3 Gordon Jin 2007-11-19 18:08:43 UTC
There have been some related fixes in xf86-video-intel 2.2.0. Could you try it?
Comment 4 Orion Poplawski 2007-12-01 20:25:13 UTC
2.2.0 exhibits the same behavior.
Comment 5 Jesse Barnes 2007-12-04 17:09:06 UTC
Created attachment 12950 [details]
latest backlight fixes

Does this patch work for you?
Comment 6 Jesse Barnes 2007-12-04 18:31:23 UTC
Adding Sergio to this bug as I think he was seeing similar issues.
Comment 7 Jesse Barnes 2007-12-04 18:40:09 UTC
Created attachment 12954 [details]
backlight fixes

Save backlight state at suspend/leaveVT time
Don't set brightness to maximum if it was zero (a valid value).
Save the current state at startup.
Comment 8 Lukas Hejtmanek 2007-12-05 01:02:44 UTC
seems to be working.
Comment 9 Jesse Barnes 2007-12-05 08:10:47 UTC
Ok, fix pushed.  Thanks a lot for your testing & suggestions.
Comment 10 Orion Poplawski 2007-12-06 14:31:58 UTC
Um, worked fine until suspend/resume.  Then self brightening came back.
Comment 11 Jesse Barnes 2007-12-06 15:02:03 UTC
Hm, that may be a separate problem... are you using vbetool post in your resume path?
Comment 12 Jesse Barnes 2007-12-06 15:02:30 UTC
Oh and does the brightness go back to maximum after a VT switch?  If not, I think you have a separate suspend/resume problem.
Comment 13 Sérgio M. Basto 2007-12-06 16:41:42 UTC
I don't had many time to test it , but so far I don't see any regression ...

 (In reply to comment #10)
> Um, worked fine until suspend/resume.  Then self brightening came back.
> 
What is your kernel version ? 
Comment 14 Orion Poplawski 2007-12-06 19:27:27 UTC
VT switch apparently does not trigger the brightening.

kernel is 2.6.23.1-21.fc7, latest F7 updates kernel.
Comment 15 Orion Poplawski 2007-12-06 19:28:30 UTC
(In reply to comment #11)
> Hm, that may be a separate problem... are you using vbetool post in your resume
> path?
> 

No idea.  Just doing stock KDE kpowersave suspend to RAM.
Comment 16 Sérgio M. Basto 2007-12-07 06:24:06 UTC
(In reply to comment #14)
> VT switch apparently does not trigger the brightening.
> 
> kernel is 2.6.23.1-21.fc7, latest F7 updates kernel.
> 

Could you try a 2.6.22 from fedora and report any difference ? 
Comment 17 Jesse Barnes 2007-12-07 10:05:05 UTC
Well, if VT switch doesn't cause the problem, then there's a bug in your suspend/resume path somewhere.  My guess is that your distro is using vbetool post on resume, which resets the chip and may increase the brightness to a default (high) level.

A proper fix for this is to use the latest DRM bits, which include suspend/resume functionality for i915, and disable vbetool on your system.

Either way, you should open a new bug for that problem if the above doesn't work for you.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.