Bug 13396 - Avoiding the use of the "any" symbol (cs and hr)
Summary: Avoiding the use of the "any" symbol (cs and hr)
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-26 04:30 UTC by Loïc Minier
Modified: 2008-02-26 06:23 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
avoid using the "any" symbol in cs and hr (10.82 KB, patch)
2007-11-26 04:30 UTC, Loïc Minier
Details | Splinter Review

Description Loïc Minier 2007-11-26 04:30:13 UTC
Hi,

console-setup doesn't understand the "any" symbol and this used to break the support for Croats, Slovenians and Bosnians layouts in Ubuntu (and probably Debian).  (See https://bugs.launchpad.net/bugs/93077 for details.)  This was worked around by rewriting cs and hr symbols to not use "any", I'll attach this patch.

It seems it would be easier to simply avoid using "any" as so few keymaps use it.

Thanks!
Comment 1 Loïc Minier 2007-11-26 04:30:47 UTC
Created attachment 12721 [details] [review]
avoid using the "any" symbol in cs and hr
Comment 2 Sergey V. Udaltsov 2007-11-26 14:44:40 UTC
First, there is no symbols/cs any more. Also, 'any' is a valid keysym name. I am not excited about copying entire 'us' layout, with all fairness. Would it be possible to fix console-setup tools instead? If they support XKB syntax - they should support it fully, shouldn't they?
Comment 3 Colin Watson 2008-02-26 06:05:26 UTC
Yes, this was a workaround we were employing for the time being, and I agree that it was pretty nasty. Upon investigating this in console-setup again today, I found that the fix is in fact remarkably easy:

=== modified file 'Keyboard/ckbcomp'
--- Keyboard/ckbcomp    2008-01-28 17:56:10 +0000
+++ Keyboard/ckbcomp    2008-02-26 14:00:19 +0000
@@ -2703,7 +2703,7 @@
        my $level = 0;
        for my $symbol (@_) {
            if ($symbol !~ /\(/ && $symbol =~ /./
-               && ($symbol !~ /^nosymbol$/i
+               && ($symbol !~ /^(?:nosymbol|any)$/i
                    || ! defined $symbols_table{$code}[$group][$level])) {
                $symbols_table{$code}[$group][$level] = $symbol;
            }

Feel free to close this bug; I'll revert the workaround in Ubuntu's xkeyboard-config packages too. Thanks!
Comment 4 Sergey V. Udaltsov 2008-02-26 06:23:31 UTC
> Feel free to close this bug; I'll revert the workaround in Ubuntu's
> xkeyboard-config packages too. Thanks!

You're mostly welcome. Thanks for your help!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.