Bug 13461 - move XF86Forward and XF86Back into inet(media_common)
Summary: move XF86Forward and XF86Back into inet(media_common)
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-30 07:52 UTC by Ani
Modified: 2007-12-10 14:42 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
sample patch (7.04 KB, patch)
2007-11-30 07:53 UTC, Ani
Details | Splinter Review

Description Ani 2007-11-30 07:52:39 UTC
If we move
    key <I69>	{	[ XF86Forward		] };
    key <I6A>	{	[ XF86Back		] };
into inet(media_common) section, Thinkpad keyboards will have working browser keys without any further configuration.
I am attaching a sample patch which addes those keys to media_common variant, and removes redundant definitionas from all other variants which include media_common.
Comment 1 Ani 2007-11-30 07:53:02 UTC
Created attachment 12870 [details] [review]
sample patch
Comment 2 Sergey V. Udaltsov 2007-11-30 14:34:01 UTC
Thanks for the good idea. I did not take your patch literally - but you gave me a good idea
Comment 3 Ani 2007-11-30 14:53:53 UTC
There seems to be a problem with xkb_symbols "azonaRF2300".
It needs
include "inet(media_common)" and
key <I6A>   {       [ XF86Back              ]       };
should be removed.
Comment 4 Sergey V. Udaltsov 2007-11-30 14:56:41 UTC
I see no keys from media_common in azonaRD2300. And I see no proper XF86Forward there...

(In reply to comment #3)
> There seems to be a problem with xkb_symbols "azonaRF2300".
> It needs
> include "inet(media_common)" and
> key <I6A>   {       [ XF86Back              ]       };
> should be removed.
> 

Comment 5 Ani 2007-11-30 15:01:06 UTC
I meant include "inet(nav_common)"
You just removed XF86Forward.
inet version 1.72 had XF86Forward and XF86Back
http://webcvs.freedesktop.org/xkeyboard-config/xkeyboard-config/symbols/inet?revision=1.72&view=markup
Comment 6 Sergey V. Udaltsov 2007-11-30 15:03:39 UTC
oops you are right, I've lost it. Thank you very much for spotting the issue.
Comment 7 Ani 2007-12-09 19:37:03 UTC
Now media keys don't work for inet(thinkpad) layout.
include "inet(nav_common)"
should be replaced with
include "inet(media_nav_common)"
Comment 8 Sergey V. Udaltsov 2007-12-10 14:42:20 UTC
Thanks, it is fixed now.



Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.