Bug 13622 - Request for API addition for client encoding specifiable uim_switch_im()
Summary: Request for API addition for client encoding specifiable uim_switch_im()
Status: RESOLVED FIXED
Alias: None
Product: UIM
Classification: Unclassified
Component: libuim (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: YamaKen
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 7164
  Show dependency treegraph
 
Reported: 2007-12-12 08:40 UTC by Etsushi Kato
Modified: 2008-01-03 05:23 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Proposed patch for API addition (1.90 KB, patch)
2007-12-12 08:40 UTC, Etsushi Kato
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Etsushi Kato 2007-12-12 08:40:02 UTC
For client of libuim using non-unicode context, it is needed to fixup encoding or IM after the configuration_changed notification from IM toggle when new IM's character is not expressed in the previous IM's encoding.

So could you add a API like uim_switch_im_with_client_encoding()?  Attached file is the proposed patch, which also should fix SEGV with uim-el-agent.

If the proposed API is too specific, maybe API like uim_switch_client_encoding() will be another candidate to fix the problem.
Comment 1 Etsushi Kato 2007-12-12 08:40:57 UTC
Created attachment 13064 [details] [review]
Proposed patch for API addition
Comment 2 YamaKen 2007-12-27 06:32:52 UTC
Hi Etsushi, thank you for the patch.

I prefer to keep the enconding switching functionality orthogonal to the IM switching.

How about this?

void uim_set_client_encoding(uim_context uc, const char *encoding);
Comment 3 Etsushi Kato 2007-12-27 07:54:48 UTC
(In reply to comment #2)
> I prefer to keep the enconding switching functionality orthogonal to the IM
> switching.
> 
> How about this?
> 
> void uim_set_client_encoding(uim_context uc, const char *encoding);

Sounds reasonable to me.  Please go ahead with that.

Comment 4 YamaKen 2007-12-29 05:14:09 UTC
The API has been added in r5069. Nosuke, please fix the uim.el problem with it.
Comment 5 Konosuke Watanabe 2008-01-01 12:26:49 UTC
> Nosuke, please fix the uim.el problem with it.

Sorry about the late response.
I've modified uim.el to use the new API.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.