Bug 13664 - sun type6 keyboard support
Summary: sun type6 keyboard support
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-14 21:54 UTC by Jeremy Huddleston Sequoia
Modified: 2008-02-12 12:34 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
xkeyboard-config-sun6.patch (20.29 KB, patch)
2007-12-14 21:55 UTC, Jeremy Huddleston Sequoia
Details | Splinter Review
xkeyboard-config-sun6.patch (16.00 KB, patch)
2007-12-14 22:18 UTC, Jeremy Huddleston Sequoia
Details | Splinter Review
xkeyboard-config-sun6.patch (18.78 KB, patch)
2007-12-16 11:54 UTC, Jeremy Huddleston Sequoia
Details | Splinter Review
xkeyboard-config-sun6.patch (11.55 KB, patch)
2008-02-06 17:56 UTC, Jeremy Huddleston Sequoia
Details | Splinter Review
additional patch for base.xml.in (695 bytes, patch)
2008-02-06 18:19 UTC, Jeremy Huddleston Sequoia
Details | Splinter Review

Description Jeremy Huddleston Sequoia 2007-12-14 21:54:56 UTC
Here's a patch to fix up sun type6 keyboard support
Comment 1 Jeremy Huddleston Sequoia 2007-12-14 21:55:18 UTC
Created attachment 13121 [details] [review]
xkeyboard-config-sun6.patch
Comment 2 Jeremy Huddleston Sequoia 2007-12-14 22:18:57 UTC
Created attachment 13122 [details] [review]
xkeyboard-config-sun6.patch
Comment 3 Jeremy Huddleston Sequoia 2007-12-16 11:54:40 UTC
Created attachment 13144 [details] [review]
xkeyboard-config-sun6.patch
Comment 4 Sergey V. Udaltsov 2007-12-17 12:56:44 UTC
Great! Thanks, committed.
Comment 5 Jeremy Huddleston Sequoia 2008-02-06 14:53:20 UTC
The keycodes/sun hunk of the patch is not in cvs.

There are also still a few minor issues in the keymapping that still need to be addressed, so I'll add a new patch against cvs that includes the missing hunk and the other issues soon.
Comment 6 Sergey V. Udaltsov 2008-02-06 15:16:07 UTC
Looking forward to new patch, thanks!
Comment 7 Jeremy Huddleston Sequoia 2008-02-06 17:56:00 UTC
Created attachment 14190 [details] [review]
xkeyboard-config-sun6.patch

Applies to current cvs master.

Big cleanup of sun symbols.  Now using inet for standardized symbols instead of old sun symbols for volume, cut, paste, etc.

Cleans up xmodmap by avoiding pulling in all of pc.  xmodmap now clean:
shift       Shift_L (0x32),  Shift_R (0x3e)
lock        Caps_Lock (0x42)
control     Control_L (0x25),  Control_R (0x6d)
mod1        Meta_L (0x73),  Meta_R (0x74)
mod2        Mode_switch (0x71)
mod3        Num_Lock (0x4d)
mod4        Alt_L (0x40)
mod5      

Verified working on type6 usb on linux/x86_64 and type 5/6 serial on linux/sparc.
Comment 8 Jeremy Huddleston Sequoia 2008-02-06 18:06:05 UTC
Sergey, there is actually one remaining issue that I can't seem to tackle, and maybe you can point me in the right direction.  Capslock and numlock indicator lights work as expected, but scroll lock and compose (Multi_key) don't.  Multi_key and Scroll_Lock are mapped right according to xev, and doing multi-key followed by ' followed by a produced รก correctly

I have these in my keycodes definition:
include "xfree86"
indicator 4 = "Compose"

so scroll lock indicator should be coming in from xfree86.

The scroll lock indicator light works fine outside of X.

Any idea why these indicators aren't working right?

Thanks.
Comment 9 Jeremy Huddleston Sequoia 2008-02-06 18:19:02 UTC
Created attachment 14191 [details] [review]
additional patch for base.xml.in

That last patch didn't include a definition in base.xml.in.  This patch contains just the xml update.
Comment 10 Sergey V. Udaltsov 2008-02-07 00:54:28 UTC
Just out of curiosity: shouldn't "sunbase", "left_funkeys", "volumekeys" be marked as hidden?
Comment 11 Jeremy Huddleston Sequoia 2008-02-11 14:37:39 UTC
(In reply to comment #10)
> Just out of curiosity: shouldn't "sunbase", "left_funkeys", "volumekeys" be
> marked as hidden?
>

That would probably be best, yes.
Comment 12 Sergey V. Udaltsov 2008-02-12 12:34:18 UTC
Committed, thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.