Reported by Hongjiu Lu in Red Hat bugzilla, along with a patch to fix the small typo. Link to Red Hat bugzilla for full bug report: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=126586
Created attachment 902 [details] [review] [FIXED_X11R68x] xorg-x11-6.8.0-ia64-460gx-pci-typo.patch
This should be applied to CVS head, XORG-6_8-branch and XORG-6_7-branch as it is a small obvious simple fix.
Comment on attachment 902 [details] [review] [FIXED_X11R68x] xorg-x11-6.8.0-ia64-460gx-pci-typo.patch Sorry for the late nomination, I was going through our RPM today and found this. The patch is a bit tricky, because 1) this code uses assignments in if conditionals in other places and 2) there are extra ( ) around the assignment as if to silence the warning. However, looking at the context, it's clear that the patch doesn't break anything, since just below the if statement there is code dereferencing pBusInfo, but if this code is reached pBusInfo would be NULL. We have this patch in our RPM.
Comment on attachment 902 [details] [review] [FIXED_X11R68x] xorg-x11-6.8.0-ia64-460gx-pci-typo.patch Approval for X11R6.8.x stable branch granted in the 2004-12-13 release-wranglers phone call.
Comment on attachment 902 [details] [review] [FIXED_X11R68x] xorg-x11-6.8.0-ia64-460gx-pci-typo.patch Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.365.2.103; previous revision: 1.365.2.102 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/hw/xfree86/os-support/bus/460gxPCI.c,v <-- 460gxPCI.c new revision: 1.1.1.2.6.2; previous revision: 1.1.1.2.6.1 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org...
so is this in head, and if so can we close this please?
yes, this is fixed in HEAD: http://cvs.freedesktop.org/xorg/xc/programs/Xserver/hw/xfree86/os-support/bus/460gxPCI.c?r1=1.2&r2=1.3 closing.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.