Bug 13954 - Geometry for thinkpad 60 series
Summary: Geometry for thinkpad 60 series
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2008-01-07 05:12 UTC by Alexey Ten
Modified: 2008-01-11 14:40 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
geometry (8.72 KB, patch)
2008-01-07 05:15 UTC, Alexey Ten
Details | Splinter Review

Description Alexey Ten 2008-01-07 05:12:25 UTC
This patch provides geometry for IBM (Lenovo) ThinkPad 60 series
Namely IBM ThinkPad R60/T60/Z60m/Z60t/R61/T61/Z61m/Z61t
Comment 1 Alexey Ten 2008-01-07 05:15:04 UTC
Created attachment 13567 [details] [review]
geometry
Comment 2 Sergey V. Udaltsov 2008-01-07 15:10:13 UTC
Very well done patch, actually.
A couple of issues:
1. You forgot the vendor tag for base.xml.in. Not a big deal, I've added it.
2. For some reason, the whole keyboard look black in gnome-keyboard-properties. I'll try to figure out why.
Comment 3 Alexey Ten 2008-01-09 20:30:45 UTC
(In reply to comment #2)
> 2. For some reason, the whole keyboard look black in gnome-keyboard-properties.
> I'll try to figure out why.

AFAIK, the problem is in Fn key, which has no keycode. The same problem exists in original thinkpad(us) layout. Adding fake keycode for Fn resolves the issue.

BTW, Fn key generates the same keycode (227) as Menu key, but only if it's pressed alone or with key which doesn't give valid combination with Fn.
I.e. Fn+Space gives keycode 249, while Fn+Z (or any other letter) gives 227.
Comment 4 Sergey V. Udaltsov 2008-01-11 14:40:28 UTC
Actually, it paints ok with the latest libgnomekbd - so let's leave it as it is. Though having a key without keycode is a bit odd, I must admit.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.