Bug 14151 - Show translations for gnome-packagekit applications at runtime
Summary: Show translations for gnome-packagekit applications at runtime
Status: RESOLVED FIXED
Alias: None
Product: PackageKit
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Richard Hughes
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-20 07:20 UTC by Luca Ferretti
Modified: 2008-01-22 01:59 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
The proposed patch (9.46 KB, patch)
2008-01-20 07:20 UTC, Luca Ferretti
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Luca Ferretti 2008-01-20 07:20:15 UTC
Created attachment 13815 [details] [review]
The proposed patch

All gnome-packagedir applications are missing the *textdomain* functions calls, plus the -DLOCALEDIR in Makefile.am

This means that, at runtime, translations are not showed, while available.

Here is a patch to fix this. The patch also fix the following additional i18n/l10n issues that I found editing the sources:

  * add N_() for GOptionEntry options (translate them too) in all apps
  * convert _() to N_() in pk-prefs.c -> #define (N_() is the one to use
    when strings are not direclty used)
  * one or two missed _() here and there.
Comment 1 Luca Ferretti 2008-01-22 01:59:36 UTC
Committed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.