Bug 14207 - [965GM][Intel-2.2-branch] Driver fails to build if pciaccess<0.10
Summary: [965GM][Intel-2.2-branch] Driver fails to build if pciaccess<0.10
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: unspecified
Hardware: Other All
: lowest trivial
Assignee: Wang Zhenyu
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-22 13:50 UTC by Erik Andren
Modified: 2008-01-24 06:45 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Erik Andren 2008-01-22 13:50:54 UTC
Using Ubuntu Hardy Alpha 3 on a 64 bit system.
If the libpciaccess libraries are installed the configure script enable pciaccess and subsequently fails with the following error message:

make[3]: Entering directory `/home/erik/Utveckling/xf86-video-intel/src/reg_dumper'
gcc -DHAVE_CONFIG_H -I. -I../..     -Wall -Wpointer-arith -Wstrict-prototypes 	-Wmissing-prototypes -Wmissing-declarations 	-Wnested-externs -fno-strict-aliasing -I./.. -DREG_DUMPER -g -O2 -MT intel_reg_dumper-main.o -MD -MP -MF .deps/intel_reg_dumper-main.Tpo -c -o intel_reg_dumper-main.o `test -f 'main.c' || echo './'`main.c
main.c: In function 'main':
main.c:72: warning: implicit declaration of function 'pci_device_map_range'
main.c:72: warning: nested extern declaration of 'pci_device_map_range'
main.c:75: error: 'PCI_DEV_MAP_FLAG_WRITABLE' undeclared (first use in this function)
main.c:75: error: (Each undeclared identifier is reported only once
main.c:75: error: for each function it appears in.)
make[3]: *** [intel_reg_dumper-main.o] Error 1
make[3]: Leaving directory `/home/erik/Utveckling/xf86-video-intel/src/reg_dumper'

This is both with the shipping 0.8.0 version and a home built 0.9.1 version of the libpciaccess library.

If i remove the header, the build succeeds.
Comment 1 Gordon Jin 2008-01-22 17:48:54 UTC
You should upgrade libpciaccess.

Anyway, it will be good for us to add a check "disable the tools if < 0.10". Assigning it to Zhenyu.
Comment 2 Julien Cristau 2008-01-24 06:45:52 UTC
(In reply to comment #1)
> You should upgrade libpciaccess.
> 
> Anyway, it will be good for us to add a check "disable the tools if < 0.10".
> Assigning it to Zhenyu.
> 
I've pushed a patch to this effect.

commit 94a18fa1f8141837bdab32e545da7a7aed1cc396
Author: Julien Cristau <jcristau@debian.org>
Date:   Thu Jan 24 15:24:40 2008 +0100

    Don't build reg_dumper if we don't have pciaccess 0.10.0
    
    The pci_device_map_range() function was added in libpciaccess 0.10.0, and
    is used by the reg_dumper tool.  Don't try to build it if we have an older
    libpciaccess.
    Also make sure that util-macros >= 1.1.3 is available when running autoconf,
    because it's required for the PACKAGE_VERSION_* macros.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.