Bug 14319 - Changing olpc-da to olpc-fa in symbols/af
Summary: Changing olpc-da to olpc-fa in symbols/af
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-31 08:12 UTC by Arjun Sarwal
Modified: 2008-01-31 23:42 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch (376 bytes, patch)
2008-01-31 08:12 UTC, Arjun Sarwal
Details | Splinter Review
Patch2 (991 bytes, patch)
2008-01-31 13:40 UTC, Arjun Sarwal
Details | Splinter Review

Description Arjun Sarwal 2008-01-31 08:12:56 UTC
Created attachment 14055 [details] [review]
Patch

To conform with the standard naming convention, the olpc section for Dari should be named as olpc-fa (fa is the language code for Farsi)
I should've given it (the naming) more thought earlier itself.
Comment 1 Arjun Sarwal 2008-01-31 13:40:41 UTC
Created attachment 14061 [details] [review]
Patch2

Patch that
(1) Correctly names olpc-da as olpc-fa to confirm with the standard name convention
(2) Adds af to olpclayouts in base.lists.part 
(3) Makes the olpc-da to olpc-fa change in base.xml.in

Let me know if something has not been done correctly. Thanks.
Comment 2 Sergey V. Udaltsov 2008-01-31 14:05:46 UTC
Great! Committed!
Comment 3 Bernie Innocenti 2008-01-31 17:18:00 UTC
(In reply to comment #1)

> Let me know if something has not been done correctly. Thanks.

A minor note: the default diff format is generally considered dreadful to look at.

Many people prefer the unified (-u) format.  More rarely, the context (-c) format.
Comment 4 Sergey V. Udaltsov 2008-01-31 23:42:22 UTC
> Many people prefer the unified (-u) format.  More rarely, the context (-c)
> format.
> 
Good point. Thanks Bernardo


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.