Bug 144 - patch for better integration of libtool
Summary: patch for better integration of libtool
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xlib (show other bugs)
Version: unspecified
Hardware: Other All
: high normal
Assignee: Jim Gettys
QA Contact:
Depends on:
Reported: 2003-11-15 08:39 UTC by Luciano Montanaro
Modified: 2011-10-15 17:23 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Add missing dependencies to Makefile.am (1.77 KB, patch)
2003-11-15 08:41 UTC, Luciano Montanaro
no flags Details | Splinter Review

Description Luciano Montanaro 2003-11-15 08:39:03 UTC
This patch should be able to detect that a stale libtool script 
is in the current directory and recreate it.
Comment 1 Luciano Montanaro 2003-11-15 08:41:06 UTC
Created attachment 71 [details] [review]
Add missing dependencies to Makefile.am 

The patch touches the Xau and X11 directories only, by now.
I'll see if it is needed elsewhere at a later time.
Comment 2 Jim Gettys 2003-11-17 12:42:19 UTC
What happens if libtool isn't installed?

Automake should be doing this automatically...  If not,
I wonder why we should do it?
Comment 3 Luciano Montanaro 2003-11-17 23:34:48 UTC
Well, I made this change following the instructions of the libtool info pages.  
Maybe it's a new development in libtool. The page also mentions that 
AC_PROG_LIBTOOL is the preferred form to check for libtool presence. 
It should make no difference if libtool is not installed, since then 
LIBTOOL_DEPS will be empty, and the libtool: target will not be rebuilt. 
On the other hand, I am not definitely sure this really helped in my case.    
Comment 4 Stuart Anderson 2004-02-19 08:11:46 UTC
Additional interesting improvment here would be a more accurate way of saying 
"Is there room in the buffer" and should cause a higher hitrate on using the 
existing buffer vs having to allocate a buffer: 
diff -c -r3.6 XKBSetGeom.c 
*** XKBSetGeom.c        1 Feb 2004 16:16:03 -0000       3.6 
--- XKBSetGeom.c        19 Feb 2004 16:08:39 -0000 
*** 400,406 **** 
      sz+= _SizeGeomDoodads(geom->num_doodads,geom->doodads); 
      sz+= _SizeGeomKeyAliases(geom); 
      req->length+= (sz/4); 
!     if (sz<BUFSIZE) { 
        BufAlloc(char *,wire,sz); 
        tbuf= NULL; 
--- 400,406 ---- 
      sz+= _SizeGeomDoodads(geom->num_doodads,geom->doodads); 
      sz+= _SizeGeomKeyAliases(geom); 
      req->length+= (sz/4); 
!     if (sz<(dpy->bufmax-dpy->buffer)) { 
        BufAlloc(char *,wire,sz); 
        tbuf= NULL; 
Comment 5 Stuart Anderson 2004-02-19 08:25:18 UTC
Grrr..... bugzilla bit me. That last comment was meant for a different bug. 
Sorry. Anyone know how to delete comments in a bug? 
Comment 6 Jeremy Huddleston Sequoia 2011-09-24 16:36:20 UTC
Way old.  This is likely fixed when we went modular

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.