Created attachment 71 [details] [review]
Add missing dependencies to Makefile.am 

The patch touches the Xau and X11 directories only, by now.
I'll see if it is needed elsewhere at a later time.

What happens if libtool isn't installed?


Automake should be doing this automatically...  If not,
I wonder why we should do it?

Well, I made this change following the instructions of the libtool info pages.  
Maybe it's a new development in libtool. The page also mentions that 
AC_PROG_LIBTOOL is the preferred form to check for libtool presence. 
It should make no difference if libtool is not installed, since then 
LIBTOOL_DEPS will be empty, and the libtool: target will not be rebuilt. 
 
On the other hand, I am not definitely sure this really helped in my case.    

Additional interesting improvment here would be a more accurate way of saying 
"Is there room in the buffer" and should cause a higher hitrate on using the 
existing buffer vs having to allocate a buffer: 
 
diff -c -r3.6 XKBSetGeom.c 
*** XKBSetGeom.c        1 Feb 2004 16:16:03 -0000       3.6 
--- XKBSetGeom.c        19 Feb 2004 16:08:39 -0000 
*************** 
*** 400,406 **** 
      sz+= _SizeGeomDoodads(geom->num_doodads,geom->doodads); 
      sz+= _SizeGeomKeyAliases(geom); 
      req->length+= (sz/4); 
!     if (sz<BUFSIZE) { 
        BufAlloc(char *,wire,sz); 
        tbuf= NULL; 
      } 
--- 400,406 ---- 
      sz+= _SizeGeomDoodads(geom->num_doodads,geom->doodads); 
      sz+= _SizeGeomKeyAliases(geom); 
      req->length+= (sz/4); 
!     if (sz<(dpy->bufmax-dpy->buffer)) { 
        BufAlloc(char *,wire,sz); 
        tbuf= NULL; 
      } 
 

Grrr..... bugzilla bit me. That last comment was meant for a different bug. 
Sorry. Anyone know how to delete comments in a bug? 

Way old.  This is likely fixed when we went modular