Created attachment 14706 [details] [review] 0001-Add-XORG_CHECK_SYMBOLS-and-XORG_WARN_CFLAGS-macros.patch I did not add the other modified files, including configure.ac's and Makefile.am's a I would like to know how people would prefer, i.e. have modules being able to be compiled with hidden symbols in a "by directory" basis, or a global flag? Other macros can be useful, but I added in this patch only the minimally necessary ones. Other macros would be useful to avoid too much cut&pasting and then having several files with different versions of the same original shell/m4 code. Later I will check the symbols in the new "compilable" modules. But I can tell in advance that there are some that compile, but still have missing symbols, i.e. instant apparent sever crash for a new user, possibly with an unusable console.
Created attachment 15276 [details] [review] 0001-Add-XORG_CHECK_SYMBOLS-and-XORG_WARN_CFLAGS-macros.patch New version that applies cleanly to git master.
Created attachment 15325 [details] [review] 0001-Add-XORG_CHECK_SYMBOLS-and-XORG_WARN_CFLAGS-macros.patch This updated version checks of #defined __GNUC__ instead of including Xfuncproto.h. It is not required to check gcc version as it is "trying" to compile the small code to check for visibility support. Not including Xfuncproto.h is required, because it would include the already installed Xfuncproto.h in the default search path, that may not match the new Xfuncproto.h.
Created attachment 16467 [details] [review] 0001-Add-XORG_CHECK_SYMBOLS-and-XORG_WARN_CFLAGS-macros.patch Remaking patch with a minor modification. To be cached, variables must contain "_cv_", so corrected accordingly the variable.
visibility was add to XORG_CFLAGS, and compiler warnings macro to util-macros 1.2.0.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.