Bug 14751 - If nick is taken try adding a "_"
Summary: If nick is taken try adding a "_"
Status: RESOLVED MOVED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: idle (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
: 23729 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-02-29 09:32 UTC by Ted Gould
Modified: 2019-12-03 19:24 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch to telepathy idle 0.1.2 (1.93 KB, patch)
2008-02-29 09:32 UTC, Ted Gould
Details | Splinter Review

Description Ted Gould 2008-02-29 09:32:57 UTC
Created attachment 14717 [details] [review]
Patch to telepathy idle 0.1.2

Basically this is a small patch that adds to the nick taken callback to add on characters to the nick so that you can eventually log in.

If you're using Ubuntu you can try it by using the version in my PPA: http://launchpad.net/~ted-gould/+archive
Comment 1 Jonathon Jongsma 2009-01-29 17:31:09 UTC
I'm wondering if this shouldn't instead be handled by the client (e.g. empathy).  Because different clients might have different approaches to the problem.  Also, if we did automatic nick-changing in the connection manager, we'd need to have some way to communicate back up to the client that "the nick you gave us didn't work, so I used this one instead".  That seems like more trouble than just having the client take responsibility for automatically retrying with a modified nick.
Comment 2 Will Thompson 2009-09-06 02:56:53 UTC
*** Bug 23729 has been marked as a duplicate of this bug. ***
Comment 3 Sjoerd Simons 2010-04-02 08:38:17 UTC
Review of attachment 14717 [details] [review]:

Test comment for splinter

::: telepathy-idle-0.1.2/src/idle-connection.c
@@ +725,2 @@
+	if (conn->parent.status == TP_CONNECTION_STATUS_CONNECTING) {
+		/*  Code to make it so that nicks don't collide.  If the nick

Test

@@ +744,3 @@
+			gchar msg[IRC_MSG_MAXLEN+1];
+			g_snprintf(msg, IRC_MSG_MAXLEN+1, "NICK %s", priv->nickname);
+			send_irc_cmd(conn, msg);

Test review comment for splinter: g_strdup_printf is awesome :)
Comment 4 Omer Akram 2010-08-31 01:44:38 UTC
does this patch still apply?
Comment 5 Debarshi Ray 2012-10-29 16:39:56 UTC
Corresponding Empathy bug: https://bugzilla.gnome.org/show_bug.cgi?id=680024
Comment 6 GitLab Migration User 2019-12-03 19:24:15 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-idle/issues/2.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.