We should decline C++ style pointer notation such as 'char*' or 'void*'. Almost have been rewritten, but gtk-related codes are left untouched since I don't know coding style of GTK+ well. In r1326, they have been replaced with traditional 'char *' or 'void *'. Even if it does not cause compile error, I think that such coding style is a bad habit that leads a human error due to misinterpretation about type declaration. For example, a declaration 'char* a, b, c;' may sometimes be interpreted as 'char* a; char* b; char* c;' by less-experienced C/C++ programmers. But it of course results 'char* a; char b; char c;'. So we should write pointers as 'char *' style. 'char *a, b, c;' will not cause such misinterpretation. We should remind that the uim library will be used by wide-range of programmers. We should eliminate any source of human errors. Since I don't know the coding style of GTK+ well, gtk-related codes have been left untouched about such pointer notations. We should also rewrite them if no recommendation about C++ style pointer notation exists for GTK+.
I checked gtk-im-uim.c and uim-candwin-gtk.c and fixed 1 'gchar*' style definition. (See rev1569) Now I think all C++ style pointer notation is fixed in Gtk+ related code. Could I close this bug?
Not yet. I've checked it by following command. $ find . \( -name '*.c' -or -name '*.cpp' -or -name '*.h' \) -exec egrep -H '[_a-zA-Z0-9]\*\b' {} \;
Oops, the previous command is wrong. $ find . \( -name '*.c' -or -name '*.cpp' -or -name '*.h' \) -exec egrep -H '[_a-zA-Z0-9]\*' {} \;
I'm not edit .cpp files, but I fixed all C++ style pointer notations from .c files.
Slow down and check double. There are many C++ style notations.
Finished in r4780.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.