Bug 14953 - patch for checking double scan mode on correct crtc
Summary: patch for checking double scan mode on correct crtc
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/nouveau (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Nouveau Project
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-11 00:32 UTC by Danny
Modified: 2008-03-11 10:16 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch for getting correct overlay crtc (2.35 KB, patch)
2008-03-11 00:32 UTC, Danny
no flags Details | Splinter Review
updated patch (3.32 KB, patch)
2008-03-11 05:22 UTC, Danny
no flags Details | Splinter Review

Description Danny 2008-03-11 00:32:18 UTC
Created attachment 15028 [details] [review]
patch for getting correct overlay crtc

Last week I noticed I got occasionally problems with Xv because video was not correctly placed in the window (using the overlay). Some further investigation showed that the video was not only misplaced in the y direction, but also very elongated.

The problem was due to CurrentLayout.mode being undefined under randr12, to mode.Flags being some random number that occasionally lead the driver to think i was using a doublescan mode. This was recently fixed in git by malc0 using currentMode->Flags. However, malc0 noted in the changelog that this may also not be correct for randr12 (It works here, but I think it may in some setups not always point to the mode on the overlay crtc).

Attached patch should fix this.

Danny
Comment 1 Danny 2008-03-11 05:22:28 UTC
Created attachment 15031 [details] [review]
updated patch

obviously, the patch was wrong for the non-randr12 case. Here 's an updated version.

d.
Comment 2 Stuart Bennett 2008-03-11 10:16:56 UTC
Thanks; pushed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.