Bug 15333 - R300 + EXA + REPEAT_NORMAL bugs
Summary: R300 + EXA + REPEAT_NORMAL bugs
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xf86-video-ati maintainers
QA Contact: Xorg Project Team
Depends on:
Reported: 2008-04-02 23:43 UTC by Owen Taylor
Modified: 2008-04-03 11:46 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Patch with above described fixes (1.94 KB, patch)
2008-04-02 23:43 UTC, Owen Taylor
no flags Details | Splinter Review

Description Owen Taylor 2008-04-02 23:43:16 UTC
Created attachment 15639 [details] [review]
Patch with above described fixes

I'll attach a patch here that fixes 3 closely related issues with
acceleration of repeating sources/masks on the R300

 - The code had an incorrect check for pitch (it was using a 
   value that already had been munged to register format)
 - The code used only enabled the use of the TXPITCH register
   for non-repeating sources but it works as well for repeating
   in my testing. (This allows acceleration of width 1/2/4 
   repeating sources which are power-of-two but padded out.)
 - In the rare case that a repeating source passed the 
   incorrect pitch check, the code didn't actually turn 
   repeat on in the accelerator.

I believe this fix is R300 specific and the R100/R200 code paths
are right.
Comment 1 Alex Deucher 2008-04-03 11:46:14 UTC
Committed:  c40a7aa3989576a8144213e2f31b892d21df8686


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.