Bug 15369 - Bad optimization of OVER => SRC with RepeatNone
Summary: Bad optimization of OVER => SRC with RepeatNone
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Depends on:
Blocks: 15744
  Show dependency treegraph
Reported: 2008-04-05 11:13 UTC by Owen Taylor
Modified: 2008-06-24 09:47 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

The patch (1.92 KB, patch)
2008-04-05 11:16 UTC, Owen Taylor
no flags Details | Splinter Review

Description Owen Taylor 2008-04-05 11:13:32 UTC
The code in render/picture.c assumes that if the source drawable
doesn't have alpha then the source doesn't have alpha, but that
isn't true for RepeatNone - sampling off the edge of the picture
will introduce alpha.

Will attach a patch fixing the problem. It doesn't try to perfectly
capture every case where the optimization *is* possible, though
it does catch the simple common case where there is no transform
on the source picture.
Comment 1 Owen Taylor 2008-04-05 11:16:37 UTC
Created attachment 15706 [details] [review]
The patch
Comment 2 Adam Jackson 2008-06-24 09:47:35 UTC
Fixed in 1.5 branch and master, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.