Bug 15475 - xorg/driver/xf86-video-mga - Don't use cfb and compile warning fixes.
Summary: xorg/driver/xf86-video-mga - Don't use cfb and compile warning fixes.
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/mga (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Tilman Sauerbeck
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: janitor, patch
Depends on:
Blocks:
 
Reported: 2008-04-12 18:38 UTC by Paulo César Pereira de Andrade
Modified: 2008-06-12 12:46 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
0001-Remove-dependency-on-cfb.patch (12.18 KB, patch)
2008-04-12 18:38 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0002-Compile-warning-fixes.patch (7.19 KB, patch)
2008-04-12 18:39 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-04-12 18:38:51 UTC
Created attachment 15860 [details] [review]
0001-Remove-dependency-on-cfb.patch

Remove dependency on cfb.

  This also removes the 8/24 overlay code as it relies on cfb.

  Untested, only guaranteed to compile and not have run time
unresolved symbols (other than MGAGetClientPointer that is from
Matrox's libhal).
Comment 1 Paulo César Pereira de Andrade 2008-04-12 18:39:40 UTC
Created attachment 15861 [details] [review]
0002-Compile-warning-fixes.patch

Compile warning fixes.

  Cast types and removed/disable unused variables/functions.

  Also some minor changes to avoid warnings about mixed declarations and code,
i.e. move declarations to block of code that actually use it, and don't
add an ending semicollon to a macro that declares a local variable, as
another semicollon was added when the macro was used.
Comment 2 Tilman Sauerbeck 2008-06-12 12:46:00 UTC
Ian removed the 8+24 overlay code 9ee7b04b1fe57834a541ef27b4e25acffd3ac1c5.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.