Bug 15561 - new mime-types related to cmake
Summary: new mime-types related to cmake
Status: RESOLVED FIXED
Alias: None
Product: shared-mime-info
Classification: Unclassified
Component: freedesktop.org.xml (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Jonathan Blandford
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-17 03:39 UTC by Aleix Pol
Modified: 2008-04-21 06:21 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
xml file for the cmake mimetype. (286 bytes, application/xml)
2008-04-17 03:40 UTC, Aleix Pol
Details
Patch for the database (388 bytes, patch)
2008-04-17 06:31 UTC, Aleix Pol
Details | Splinter Review
Some cmake files (71.87 KB, application/x-tbz)
2008-04-17 07:34 UTC, Aleix Pol
Details
Proposed text/x-cmake (766 bytes, patch)
2008-04-18 07:46 UTC, Pino Toscano
Details | Splinter Review
complete changes (1.55 KB, patch)
2008-04-18 07:58 UTC, Pino Toscano
Details | Splinter Review

Description Aleix Pol 2008-04-17 03:39:44 UTC
New mimetype for the CMake source code files.

I attach here the needed information.
Comment 1 Aleix Pol 2008-04-17 03:40:41 UTC
Created attachment 15983 [details]
xml file for the cmake mimetype.
Comment 2 Bastien Nocera 2008-04-17 06:26:22 UTC
Please attach a patch (not an xml file) and provide some example files to add to the test suite.
Comment 3 Aleix Pol 2008-04-17 06:31:30 UTC
Created attachment 15986 [details] [review]
Patch for the database
Comment 4 Aleix Pol 2008-04-17 06:33:59 UTC
I don't understand what kind of files are you asking for...

Any example?
Comment 5 Bastien Nocera 2008-04-17 06:37:09 UTC
*.cmake files, so we can add those to the database. Is there any magic available to recognise CMake files from data?
Comment 6 Pino Toscano 2008-04-17 06:39:05 UTC
No, there is no real magic that can be used to recognize them.
Comment 7 Aleix Pol 2008-04-17 06:45:40 UTC
No, i don't think that there is any magic...

The only way you can do it is by checking the filename, do you still need the files?
Comment 8 Bastien Nocera 2008-04-17 07:07:11 UTC
Yes please.
Comment 9 Aleix Pol 2008-04-17 07:34:57 UTC
Created attachment 15987 [details]
Some cmake files
Comment 10 Bastien Nocera 2008-04-18 07:07:45 UTC
(In reply to comment #3)
> Created an attachment (id=15986) [details]
> Patch for the database

That's not a patch against shared-mime-info, it's against some random KDE module.
Comment 11 Aleix Pol 2008-04-18 07:28:17 UTC
You are right, could you point me out what is the correct database?
Comment 12 Bastien Nocera 2008-04-18 07:38:15 UTC
HACKING file has all the information:
http://webcvs.freedesktop.org/mime/shared-mime-info/HACKING?view=markup
Comment 13 Pino Toscano 2008-04-18 07:46:14 UTC
Created attachment 16014 [details] [review]
Proposed text/x-cmake
Comment 14 Pino Toscano 2008-04-18 07:58:45 UTC
Created attachment 16015 [details] [review]
complete changes

This patch includes the mimetype, and a sample file for the test suite.

Bastien, if it's ok for you, may I commit it?
Comment 15 Bastien Nocera 2008-04-21 06:10:58 UTC
(In reply to comment #14)
> Created an attachment (id=16015) [details]
> complete changes
> 
> This patch includes the mimetype, and a sample file for the test suite.
> 
> Bastien, if it's ok for you, may I commit it?

Go for it.
Comment 16 Pino Toscano 2008-04-21 06:21:54 UTC
Fixed in CVS.

	* freedesktop.org.xml.in:
	* tests/test.cmake:
	* tests/list: Add mime-type for CMake scripts, patch from
	Aleix Pol <aleixpol@gmail.com> (Closes: #15561)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.