Bug 15570 - [patch] bus addresses not reinitialised after dbus_shutdown()
Summary: [patch] bus addresses not reinitialised after dbus_shutdown()
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Havoc Pennington
QA Contact: John (J5) Palmieri
URL:
Whiteboard:
Keywords:
: 9770 16300 (view as bug list)
Depends on: 16166
Blocks:
  Show dependency tree / graph
 
Reported: 2008-04-17 15:52 UTC by Scott James Remnant
Modified: 2011-02-28 09:08 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
Patch to correct problem (365 bytes, patch)
2008-04-17 15:52 UTC, Scott James Remnant 		Details | Splinter Review
Patch in preferred format (745 bytes, patch)
2008-04-24 08:02 UTC, Scott James Remnant 		Details | Splinter Review
Show Obsolete (1) View All

Description Scott James Remnant 2008-04-17 15:52:28 UTC 
Created attachment 15990 [details] [review]
Patch to correct problem

The cached list of bus addresses is only initialised in init_connections_unlocked() if the initialized global is FALSE (which is the default).

addresses_shutdown_func() is called by dbus_shutdown() to clean up, but never sets initialized back to FALSE.

So after dbus_shutdown() all bus addresses are empty, and will not be reinitialized.
Comment 1 Scott James Remnant 2008-04-24 08:02:52 UTC 
Created attachment 16155 [details] [review]
Patch in preferred format
Comment 2 Colin Walters 2008-05-30 17:01:19 UTC 
commit fd32a72b2f3855ef551d0063ea1e6bea4554be08
Author: Colin Walters <walters@verbum.org>
Date:   Fri May 30 19:58:13 2008 -0400

    Bug 15570: Reset initialized state on dbus_shutdown (Scott James Remnant)
    
    	* dbus/dbus-bus.c (addresses_shutdown_func): Reset initialized back
     	to FALSE after cleaning up the address list so that it will be
     	reinitialized again if D-Bus is used after dbus_shutdown()
    	* test/name-test/test-privserver-client.c: Uncomment part of
    	test which should now pass.
Comment 3 Colin Walters 2008-06-10 15:11:53 UTC 
*** Bug 16300 has been marked as a duplicate of this bug. ***
Comment 4 Simon McVittie 2011-02-28 09:08:32 UTC 
*** Bug 9770 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.