Bug 15586 - Redirecting root window crashes X
Summary: Redirecting root window crashes X
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-18 10:03 UTC by Ben Gamari
Modified: 2008-06-24 08:05 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Patch to work around crasher (350 bytes, patch)
2008-04-18 10:04 UTC, Ben Gamari 		no flags Details | Splinter Review
View All

Description Ben Gamari 2008-04-18 10:03:04 UTC 
A code path I hit when exercising Composite crashed X when I attempted to redirect the root window as it apparently has no parent. Is checking for this and failing the correct fix?
Comment 1 Ben Gamari 2008-04-18 10:04:16 UTC 
Created attachment 16022 [details] [review]
Patch to work around crasher

Path to check for valid parent when creating new pixmap and fail if there isn't one
Comment 2 Ben Gamari 2008-06-10 13:34:43 UTC 
Any news on this? The above patch is pretty trivial and I can't see any reason why the x server should crash on redirecting the root window.
Comment 3 Adam Jackson 2008-06-24 08:05:30 UTC 
Fixed in git, although slightly differently (the check needs to happen in compRedirectWindow so we return the correct error code to the client).

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.