Bug 15654 - Please close files after opening them :-)
Summary: Please close files after opening them :-)
Status: RESOLVED FIXED
Alias: None
Product: Rarian
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Don Scorgie
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-22 09:59 UTC by Vincent Untz
Modified: 2008-07-29 11:23 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Vincent Untz 2008-04-22 09:59:28 UTC 
In rrn_reg_parse_file_full, rrn_sect_parse_file_full, rrn_reg_parse_file and rrn_sect_parse_file, fopen() is called but the files are never closed. Please use fclose() after the loop that reads the file. Else, some bad failure can happen because too many files are opened (ie, fopen() fails after a while and it crashes in fgets).
Comment 1 Don Scorgie 2008-07-29 11:23:46 UTC 
Fixed in revision 58 of SVN.  Will appear in 0.8.1

2008-07-29  Don Scorgie  <Don@Scorgie.org>
	
	* librarian/rarian-man.c: 
	* librarian/rarian-info.c:
	* librarian/rarian-reg-utils.c:
	* librarian/rarian-reg-full.c:
	Close files once they're used
	bug #15654

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.