Bug 15664 - x11.pc contains uneeded dependencies
Summary: x11.pc contains uneeded dependencies
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xlib (show other bugs)
Version: 7.3 (2007.09)
Hardware: All All
: low minor
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
: 16795 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-04-22 21:32 UTC by Paul Bender
Modified: 2009-03-12 19:56 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch that was missing from orignal bug report (not sure why) (1.70 KB, patch)
2008-04-23 06:34 UTC, Paul Bender
no flags Details | Splinter Review

Description Paul Bender 2008-04-22 21:32:15 UTC
When libX11 (version 1.1.4) is compiled with XCB enabled (--with-xcb) it includes xau and xdmcp in its x11.pc file even though it is not dependent on either libXau or libXdmcp when compiled with XCB. I have attached a patch that I use to fix the problem.
Comment 1 Michel Dänzer 2008-04-23 02:24:41 UTC
> I have attached a patch that I use to fix the problem.

No you haven't. :) (Same problem in another report of yours)
Comment 2 Paul Bender 2008-04-23 06:34:42 UTC
Created attachment 16127 [details] [review]
Patch that was missing from orignal bug report (not sure why)
Comment 3 Alan Coopersmith 2008-05-22 22:02:32 UTC
Comment on attachment 16127 [details] [review]
Patch that was missing from orignal bug report (not sure why)

That's not the right patch either 8-)   That's an xorg-server-1.4 patch, not libX11
Comment 4 Alan Coopersmith 2008-05-22 22:05:11 UTC
Comment on attachment 16127 [details] [review]
Patch that was missing from orignal bug report (not sure why)

Ah, I see what happened - your patches got swapped.   This patch is for bug #15665.  The patch for this bug is attachment #16128 [details] [review] on that bug.
Comment 5 Alan Coopersmith 2009-03-12 17:34:13 UTC
Fix pushed to git master, thanks for the patch!

 configure.ac |    1 +
 x11.pc.in    |    2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 7b9c543e7210c7da204871c31a160e79d3a949b6
Author: Paul Bender <pebender@gmail.com>
Date:   Thu Mar 12 17:11:42 2009 -0700

    Bug 15664: xau & xdmcp not needed in x11.pc dependencies when built with xcb
    
    X.Org bug #15664 <https://bugs.freedesktop.org/show_bug.cgi?id=15664>
    Patch #16128 <https://bugs.freedesktop.org/attachment.cgi?id=16128>
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>
Comment 6 Alan Coopersmith 2009-03-12 19:56:10 UTC
*** Bug 16795 has been marked as a duplicate of this bug. ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.