Bug 15773 - intel: brightness button does not work (lenovo thinkpad x300)
Summary: intel: brightness button does not work (lenovo thinkpad x300)
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: 7.3 (2007.09)
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: zhang rui
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-30 12:50 UTC by Stephan
Modified: 2008-12-28 22:01 UTC (History)
7 users (show)

See Also:
i915 platform:
i915 features:


Attachments
acpidump (60.35 KB, application/x-gzip)
2008-05-06 07:45 UTC, Stephan
no flags Details
dmesg log (11.41 KB, application/x-gzip)
2008-05-06 07:47 UTC, Stephan
no flags Details
patch: show which device the hotkey event is sent to (595 bytes, patch)
2008-05-25 19:51 UTC, zhang rui
no flags Details | Splinter Review
dmesg output (247.87 KB, text/plain)
2008-06-18 05:25 UTC, Stephan
no flags Details

Description Stephan 2008-04-30 12:50:27 UTC
I can't use the brightness buttons. xbacklight works fine.

System: opensuse 11.0 beta 1 + updates, xorg 7.3, 64bit
Comment 1 Stephan 2008-04-30 12:56:38 UTC
00:00.0 Host bridge: Intel Corporation Mobile PM965/GM965/GL960 Memory Controller Hub (rev 0c)
00:02.0 VGA compatible controller: Intel Corporation Mobile GM965/GL960 Integrated Graphics Controller (rev 0c)
00:02.1 Display controller: Intel Corporation Mobile GM965/GL960 Integrated Graphics Controller (rev 0c)
Comment 2 Gordon Jin 2008-04-30 23:32:45 UTC
probably not video driver issue. 
maybe acpi related. Rui/Hong, any comments?
Comment 3 zhang rui 2008-05-03 20:31:24 UTC
Please
make sure CONFIG_ACPI_DEBUG is set.
echo 0x44 > /sys/module/acpi/parameters/debug_layer
echo 0x8800001f > /sys/module/acpi/parameters/debug_level
press the hotkey and attach the dmesg output.
Comment 4 Stephan 2008-05-04 02:23:20 UTC
(In reply to comment #3)
> Please
> make sure CONFIG_ACPI_DEBUG is set.
> echo 0x44 > /sys/module/acpi/parameters/debug_layer
> echo 0x8800001f > /sys/module/acpi/parameters/debug_level
> press the hotkey and attach the dmesg output.
> 

set this both commands the CONFIG_ACPI_DEBUG? Or I have to recompile my kernel?
Comment 5 Stefan Dirsch 2008-05-04 02:38:06 UTC
Check with 

  zcat /proc/config.gz |grep CONFIG_ACPI_DEBUG
Comment 6 zhang rui 2008-05-04 17:44:15 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Please
> > make sure CONFIG_ACPI_DEBUG is set.
You need to rebuild the kernel if it is cleared.

> > echo 0x44 > /sys/module/acpi/parameters/debug_layer
> > echo 0x8800001f > /sys/module/acpi/parameters/debug_level
try these commands in the kernel with CONFIG_ACPI_DEBUG=y.


Comment 7 Jesse Barnes 2008-05-05 12:48:31 UTC
Yeah, this isn't an X driver bug, it's probably a kernel or desktop configuration issue (some kernels send keyboard events for the hotkeys and your desktop has to be configured to handle them).  Rui, if you're not the right owner can you assign to the thinkpad guys maybe?
Comment 8 zhang rui 2008-05-05 22:53:24 UTC
Please attach the acpidump output as well.
You can use the latest pmtools here:
http://www.kernel.org/pub/linux/kernel/people/lenb/acpi/utils/
Comment 9 Stephan 2008-05-06 07:45:04 UTC
Created attachment 16386 [details]
acpidump
Comment 10 Stephan 2008-05-06 07:47:25 UTC
Created attachment 16387 [details]
dmesg log
Comment 11 Stephan 2008-05-06 07:50:16 UTC
zcat /proc/config.gz | grep CONFIG_ACPI_DEBUG
CONFIG_ACPI_DEBUG=y
# CONFIG_ACPI_DEBUG_FUNC_TRACE is not set

I have attached dmesg and acpidump.

acpi_listen means:
^@video LCD0 00000086 00000000
^@video LCD0 00000087 00000000
Comment 12 zhang rui 2008-05-06 18:12:27 UTC
There should be two acpi_videoX directory under /sys/class/backlight after loading the ACPI video driver. One should work and another one may not.
could you please try the patch and do the same test at
http://bugzilla.kernel.org/show_bug.cgi?id=9995#c13
Comment 13 Stephan 2008-05-25 13:35:50 UTC
sorry, the patch: http://bugzilla.kernel.org/show_bug.cgi?id=9995#c13 doesn't help.
Comment 14 zhang rui 2008-05-25 19:46:14 UTC
(In reply to comment #13)
> sorry, the patch: http://bugzilla.kernel.org/show_bug.cgi?id=9995#c13 doesn't
> help.
> 
Maybe I'm not clear, the patch won't change anything, it just create a symbol link from the backlight sys class to the ACPI device node, and it may help us find out which sysfs I/F actually works.
Please refer to http://bugzilla.kernel.org/show_bug.cgi?id=9995#c16


Comment 15 zhang rui 2008-05-25 19:51:22 UTC
Created attachment 16730 [details] [review]
patch: show which device the hotkey event is sent to

Please apply this patch, and attach the dmesg output after pressing the brightness hotkey for several times.
Comment 16 Stephan 2008-06-18 05:25:07 UTC
Created attachment 17210 [details]
dmesg output
Comment 17 Stephan 2008-06-18 05:26:25 UTC
I have attached the new dmesg output.

btw: acpi_listen means now:
ibm/hotkey HKEY 00000080 00001011
video LCD0 00000087 00000000
^@ibm/hotkey HKEY 00000080 00001010
^@video LCD0 00000086 00000000
Comment 18 Stefan Dirsch 2008-11-05 22:34:55 UTC
Since Kent asked me about the severity/priority. I don't think this is a major issue.
Comment 19 zhang rui 2008-11-10 21:28:17 UTC
this is a laptop with IGD OpRegion BIOS.
please try the latest kernel  - in which IGD OpRegion patches are shipped - to see if it helps.
Comment 20 Kent Liu 2008-11-10 23:20:33 UTC
Stephan, did you try OpenSuSE 11.1 Beta 4, which uses 2.6.27 kernel?
Comment 21 zhang rui 2008-11-11 00:04:18 UTC
On Tue, 2008-11-11 at 15:20 +0800, bugzilla-daemon@freedesktop.org
wrote:
> http://bugs.freedesktop.org/show_bug.cgi?id=15773
> 
> 
> 
> 
> 
> --- Comment #20 from Kent Liu <kent.liu@intel.com>  2008-11-10 23:20:33 PST ---
> Stephan, did you try OpenSuSE 11.1 Beta 4, which uses 2.6.27 kernel?
> 
I'm afraid 2.6.27 doesn't help as the IGD patches went into 2.6.28-rcX.
better to try a vanilla kernel. :)

thanks,
rui
Comment 22 qwang13 2008-11-13 21:14:37 UTC
2.6.28-RCx kernel has been pushed into kernel. However for 2.6.27 kernel of Novell, it has no gem source code. Even we got this, it still can not help anything?
Comment 23 qwang13 2008-11-13 21:15:46 UTC
(In reply to comment #22)
> 2.6.28-RCx kernel has been pushed into kernel. However for 2.6.27 kernel of
> Novell, it has no gem source code. Even we got this, it still can not help
> anything?
> 

Sorry it is gem which has been pushed into kernel 2.6.28-RCx. For 2.6.27, there is no gem source code.
Comment 24 ykzhao 2008-11-13 22:00:44 UTC
What Rui said in comment #19(21) is right. From the acpidump it seems that this is  a laptop with IGD Opregion . 
   After the hotkey is pressed, the notification event is sent to the corresponding ACPI video device. And then brightness interface is called to change the brightness. Unfortunately the brightness can't be changed by evaluating the _BCM object if the IGD opregion patch is not shipped.
   
   
    
Comment 25 Stefan Dirsch 2008-11-22 03:09:15 UTC
So it's a kernel issue. Supposed to be fixed with openSUSE 11.2. Assuming that we'll pick up 2.6.28 or later.
Comment 26 Michael Fu 2008-12-28 22:01:04 UTC
mark fixed then.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.