Bug 1592 - fixes non-working acceleration on i810/i815 chipsets
Summary: fixes non-working acceleration on i810/i815 chipsets
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: git
Hardware: Other Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
Depends on:
Reported: 2004-10-10 09:05 UTC by Stefan Dirsch
Modified: 2004-10-26 09:54 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

p_i810-accel.diff (13.76 KB, patch)
2004-10-10 09:06 UTC, Stefan Dirsch
no flags Details | Splinter Review
Patch reverting to the original behavior (440 bytes, patch)
2004-10-26 08:28 UTC, Roman Kagan
no flags Details | Splinter Review

Description Stefan Dirsch 2004-10-10 09:05:03 UTC
I'll attach a patch, which fixes non-working acceleration on i810/i815 
Comment 1 Stefan Dirsch 2004-10-10 09:06:21 UTC
Created attachment 1075 [details] [review]
Comment 2 Stefan Dirsch 2004-10-11 02:40:43 UTC
Needs to be discussed outside of Bugzilla first.  
Comment 3 Stefan Dirsch 2004-10-12 13:18:51 UTC
reopen to close as FIXED. 
Comment 4 Stefan Dirsch 2004-10-12 13:19:29 UTC
committed to CVS. 
Comment 5 Roman Kagan 2004-10-26 08:22:32 UTC
Updating to the latest CVS (which includes your patch) produces weird artefacts
with acceleration on my i815 based systems, e.g. incompletely drawn gtk widgets.
The problem seems to be in this change:


which apparently prohibits the allocation of an LpRing at Xserver startup.  I
don't claim complete understanding of what's going on there, but reverting this
bit restores the correct behavior.  Tested on Intel D815EEA and GigaByte GA-6IEM
i815-based mobos.
Comment 6 Roman Kagan 2004-10-26 08:28:15 UTC
Created attachment 1167 [details] [review]
Patch reverting to the original behavior

Patch on top of the previous one to revert the single offending bit.
Comment 7 Roman Kagan 2004-10-26 08:48:35 UTC
BTW, the artefacts I was talking about are very similar to those people
complained about in bug #1232.
Comment 8 Egbert Eich 2004-10-27 02:41:51 UTC
Yes I agree, the patch was wrong. It should have been (... && pScrn->vtSema).
Would you please try that?
I don't know why it came out wrong. I'm going to change this in CVS.
Comment 9 Egbert Eich 2004-10-27 02:54:37 UTC
I've thrown the stupid vtSema fix out now. 
I don't thin we need it any more anyway.
Thanks Roman!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.