Bug 15951 - [i915 XvMC] failed destroy blocks
Summary: [i915 XvMC] failed destroy blocks
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: unspecified
Hardware: Other Linux (All)
: medium normal
Assignee: Wang Zhenyu
QA Contact: Xorg Project Team
Depends on:
Reported: 2008-05-15 18:28 UTC by Shuang He
Modified: 2008-05-26 01:16 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

test case (4.31 KB, text/plain)
2008-05-15 18:29 UTC, Shuang He
no flags Details
xorg log (60.23 KB, application/octet-stream)
2008-05-15 18:30 UTC, Shuang He
no flags Details
xorg conf (3.65 KB, text/plain)
2008-05-15 18:30 UTC, Shuang He
no flags Details

Description Shuang He 2008-05-15 18:28:07 UTC
System Environment:

--Platform: 945G

--2D driver:
commit 548d4c0f979a72eac5d0c9c76da12f0bd05e64e1 

--3D driver:
commit 990e010394a2685c1daeaef61cf4f7e2a0ba419e

commit cf20df39cc78203d17b99223908af388ecbf7d0e 

commit b44f2da380e78769b58c751e81f376f0fa1f48aa 


Bug detailed description:
create XvMCBlockArray and then destroy it with XvMCDestroyBlocks will fail
seems following patch will fix this:

diff --git a/src/xvmc/intel_xvmc.c b/src/xvmc/intel_xvmc.c
index 1be8cc6..3c14f73 100644
--- a/src/xvmc/intel_xvmc.c
+++ b/src/xvmc/intel_xvmc.c
@@ -513,7 +513,7 @@ Status XvMCCreateBlocks(Display *display
 Status XvMCDestroyBlocks(Display *display, XvMCBlockArray *block)
-    if (!display || block)
+    if (!display || !block)
         return BadValue;

     if (block->blocks)

Reproduce steps:
1. enable XvMC in xorg.conf
2. start X
3. compile and run attached case

Current result:
failed to destroy blocks created

Expected result:
should destroy blocks created successfully
Comment 1 Shuang He 2008-05-15 18:29:56 UTC
Created attachment 16566 [details]
test case
Comment 2 Shuang He 2008-05-15 18:30:19 UTC
Created attachment 16567 [details]
xorg log
Comment 3 Shuang He 2008-05-15 18:30:43 UTC
Created attachment 16568 [details]
xorg conf
Comment 4 Wang Zhenyu 2008-05-25 18:27:55 UTC
Good catch! Patch is pushed. Thanks.
Comment 5 Shuang He 2008-05-26 01:16:38 UTC
verified, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.