Bug 16488 - Compiling without "xv" extension is broken
Summary: Compiling without "xv" extension is broken
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 7.3 (2007.09)
Hardware: All All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-23 13:51 UTC by Maarten ter Huurne
Modified: 2008-06-23 14:57 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Do not build "kxv.c" when configured with "-disable-record" (2.55 KB, patch)
2008-06-23 13:51 UTC, Maarten ter Huurne
no flags Details | Splinter Review

Description Maarten ter Huurne 2008-06-23 13:51:51 UTC
Created attachment 17335 [details] [review]
Do not build "kxv.c" when configured with "-disable-record"

I configured KDrive (from xorg-server-1.4.2) with the "--disable-xv" flag. However, when I try to build it, I get the following compile error:

../../../../../src/xorg-server-1.4.2/hw/kdrive/src/kxv.c:53:31: X11/extensions/Xv.h: No such file or directory
../../../../../src/xorg-server-1.4.2/hw/kdrive/src/kxv.c:54:36: X11/extensions/Xvproto.h: No such file or directory

The problem seems to be that while "configure" has an option to compile without the XV extension, the Makefiles do not. The attached patch fixes this. I am not very good with autotools, so please verify it.

Bug 16486 is very similar to this one, but concerns the "record" extension.
Comment 1 Julien Cristau 2008-06-23 14:57:39 UTC
On Mon, Jun 23, 2008 at 13:51:51 -0700, bugzilla-daemon@freedesktop.org wrote:

> I configured KDrive (from xorg-server-1.4.2) with the "--disable-xv" flag.
> However, when I try to build it, I get the following compile error:
> 
> ../../../../../src/xorg-server-1.4.2/hw/kdrive/src/kxv.c:53:31:
> X11/extensions/Xv.h: No such file or directory
> ../../../../../src/xorg-server-1.4.2/hw/kdrive/src/kxv.c:54:36:
> X11/extensions/Xvproto.h: No such file or directory
> 
commit b622f6dc5d8d70d17be0374a85a9b16b43a62a01
Author: Julien Cristau <jcristau@debian.org>
Date:   Mon Jun 23 23:45:57 2008 +0200

    kdrive: fix building with --disable-xv (bug#16488)


Thanks for the report!  In the future, please try to send patches
against the git master branch, or at least don't include patches to
autogenerated files like Makefile.in.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.