Bug 16522 - Add configure option to set NOFONTSERVERACCESS (patch included)
Summary: Add configure option to set NOFONTSERVERACCESS (patch included)
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 7.3 (2007.09)
Hardware: All All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-25 11:15 UTC by Maarten ter Huurne
Modified: 2010-09-11 15:46 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Add configure option "--disable-fc", which disables font server support (2.00 KB, patch)
2008-06-25 11:15 UTC, Maarten ter Huurne
no flags Details | Splinter Review

Description Maarten ter Huurne 2008-06-25 11:15:56 UTC
Created attachment 17378 [details] [review]
Add configure option "--disable-fc", which disables font server support

In libXfont-1.3.1, there is the configure option "--disable-fc", which disables the code to connect to a font server. In xorg-server-1.4.2, in "confdefs.h" there is the #define "NOFONTSERVERACCESS", but the only way to set it is by passing "--enable-builtin-fonts" to "configure".

I think it can be useful to compile an X server which only supports client-side fonts, but does not have them built into the server itself. Therefore I would like to have a configure option to set the "NOFONTSERVERACCESS" #define.

I attached a patch that adds the "--disable-fc" configure option, which sets "NOFONTSERVERACCESS". It required adding one "#ifndef" in "dix/dixfonts.c", all other changes are in "configure.ac".

The existing "--enable-builtin-fonts" option implies "--disable-fc". This is handled by giving the "fc" option the default value "auto", which acts as "enabled". If "--enable-builtin-fonts" is given, a warning is printed and "fc" is forcibly disabled.

An alternative would be to silently disable "fc" if it was in "auto" mode and raise an error if it was in "enabled" mode (explicitly enabled by the user). I usually prefer programs to refuse invalid inputs instead of automatically correcting them. However, I looked for similar situations in "configure.ac" and saw that for example "--disable-dga" is handled by printing a warning and forced disabling, so I conformed to that.
Comment 1 Julien Cristau 2010-09-11 15:46:41 UTC
commit 75536ee80595c79bba95a1fb6844126ee08486d4
Author: Tiago Vignatti <tiago.vignatti@nokia.com>
Date:   Wed Jun 23 15:18:03 2010 +0300

    dix: use one single function to register fpe fonts

Since this commit the server supports whatever backends are configured in libXfont, so that should cover this request.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.