Bug 16836 - Better fix for gcc warning
Summary: Better fix for gcc warning
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: unspecified
Hardware: All All
: medium minor
Assignee: Wang Zhenyu
QA Contact: Xorg Project Team
Depends on:
Reported: 2008-07-24 06:34 UTC by Matt Turner
Modified: 2008-07-28 22:14 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Better fix (682 bytes, patch)
2008-07-24 06:34 UTC, Matt Turner
no flags Details | Splinter Review

Description Matt Turner 2008-07-24 06:34:36 UTC
Created attachment 17856 [details] [review]
Better fix

For commit 6ac352f146bafe3b4bb5832340eb0ccb730565d2, a better fix exists. Included patch is cleaner and removes an unnecessary variable.
Comment 1 Wang Zhenyu 2008-07-27 23:32:39 UTC
I hope to keep assert as it's.
Comment 2 Wang Zhenyu 2008-07-28 22:14:53 UTC
Matt, we have a intel-gfx mail list on fd.o, which is an ideal  place for us to review patches and comments. I don't think this cleanup is really needed, and assert in that place can give us safe-guard. You may send patch to that list, maybe others will have more comments. Bugzilla is not good for patch review, so I close this one. Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.