Bug 16874 - Can't set XkbOptions from HAL
Summary: Can't set XkbOptions from HAL
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: All All
: medium normal
Assignee: Peter Hutterer
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-28 09:41 UTC by Kanru Chen
Modified: 2008-08-04 00:25 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
0001-config-add-parsing-for-input.x11_options.XkbOptions.patch (2.36 KB, patch)
2008-07-28 22:39 UTC, Peter Hutterer 		no flags Details | Splinter Review
0001-config-support-type-strlist-for-XkbOptions-property.patch (3.45 KB, patch)
2008-07-31 22:08 UTC, Peter Hutterer 		no flags Details | Splinter Review
View All

Description Kanru Chen 2008-07-28 09:41:15 UTC 
According to config/x11-input.fdi, I can set XkbOptions by key "input.xkb.options" or "input.x11_options.XkbOptions" but neither works.
Comment 1 Peter Hutterer 2008-07-28 22:39:34 UTC 
Created attachment 17951 [details] [review]
0001-config-add-parsing-for-input.x11_options.XkbOptions.patch

This should fix it, can you please verify?
Comment 2 Kanru Chen 2008-07-29 01:41:52 UTC 
Yes, the patch fixed the bug. But there is a problem, XkbOptions was declared to be a string array now it's a string. Maybe you want it to be compatible with old configuration?
Comment 3 Julien Cristau 2008-07-29 02:53:30 UTC 
> --- Comment #2 from Kanru Chen <ckanru@gmail.com>  2008-07-29 01:41:52 PST ---
> Yes, the patch fixed the bug. But there is a problem, XkbOptions was declared
> to be a string array now it's a string. Maybe you want it to be compatible with
> old configuration?

ack, i bumped into that yesterday, i have input.xkb.options as a string
list in hal for xserver 1.4, and 1.5 only wants strings, because of
47eb658e802775021e3efec109f95431cca188ca.
Comment 4 Peter Hutterer 2008-07-31 22:08:46 UTC 
Created attachment 18051 [details] [review]
0001-config-support-type-strlist-for-XkbOptions-property.patch

here we go, this patch brings back strlist support.
Comment 5 Peter Hutterer 2008-08-04 00:25:10 UTC 
Pushed as 35b14519b4a3158592a089170ec039bbc219603e and
92c51b183c2ff06361dad7f918daed6577ba4935.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.