Bug 16945 - telepathy-butterfly crashed with NotImplementedError in _on_error()
Summary: telepathy-butterfly crashed with NotImplementedError in _on_error()
Status: RESOLVED NOTABUG
Alias: None
Product: papyon
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium critical
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/jo...
Whiteboard:
Keywords:
: 24308 28190 28593 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-08-01 06:02 UTC by Kjell Braden
Modified: 2010-06-24 05:30 UTC (History)
5 users (show)

See Also:
i915 platform:
i915 features:


Attachments
crash log (228.56 KB, application/octet-stream)
2010-03-13 04:16 UTC, Teemu Heinämäki
Details
patch (406 bytes, text/plain)
2010-03-13 18:36 UTC, Jonny Lamb
Details

Description Kjell Braden 2008-08-01 06:02:35 UTC
This issue was originally reported by chckens at Launchpad: https://launchpad.net/bugs/194494

"Occurred whilst using empathy. I'm 99% sure this issue is occurring for me because I have myself on my own contact list, if that's any help to anyone."

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/pymsn/switchboard_manager.py", line 78, in <lambda>
    lambda sb, command: self.__on_message_undelivered(command))
  File "/usr/lib/python2.5/site-packages/pymsn/switchboard_manager.py", line 150, in __on_message_undelivered
    MessageError.DELIVERY_FAILED)
  File "/usr/lib/python2.5/site-packages/pymsn/switchboard_manager.py", line 121, in _on_error
    raise NotImplementedError
NotImplementedError

Using telepathy-butterfly / pymsn 0.3.1.
Comment 1 Guillaume Desmottes 2009-02-20 16:57:03 UTC
Bug still present with pymsn 0.3.3
Comment 2 Olivier Le Thanh Duong 2009-09-20 13:38:58 UTC
Strangely this method is defined in AbstractConversation and following the MRO should be called but it's the function defined in SwitchboardClient that get called instead and raise the exception. Any idea?
Comment 3 Olivier Le Thanh Duong 2009-10-07 16:27:56 UTC
*** Bug 24308 has been marked as a duplicate of this bug. ***
Comment 4 Cristian Aravena 2009-10-07 18:40:09 UTC
14 duplicated in Ubuntu
Comment 5 Omer Akram 2010-03-10 07:24:32 UTC
whenever I get a message from msn telepathy butterfly crashes
Comment 6 Jonny Lamb 2010-03-12 17:06:39 UTC
(In reply to comment #5)
> whenever I get a message from msn telepathy butterfly crashes

Please could you post some butterfly logs? If you don't want information about your contacts to be publicly available online, feel free to email me the logs privately: jonny.lamb@collabora.co.uk
Comment 7 Teemu Heinämäki 2010-03-13 04:16:49 UTC
Created attachment 34017 [details]
crash log

Here is a log where this crash happens. The interesting part is near the end.
Comment 8 Jonny Lamb 2010-03-13 18:36:43 UTC
Created attachment 34031 [details]
patch

I added myself to my contact list and couldn't reproduce this.

I did, however, find another bug in butterfly, so that's nice. :-)

So, I was just looking at the code and it just appears as if we're getting the "NAK" command, which immediately emits the message-undelivered signal in the NAK handler, and SwitchboardClient just has a dummy NotImplementedError stub as the callback.

However, I am a little confused as to what switchboard client this is actually appearing on, as SwitchboardClient is never used directly. I'm going to guess it's SwitchboardP2PTransport, as that's the only subclass that doesn't define an _on_error method.

If you know how to use pdb, could you break when it calls _on_error (and then raises the exception) and find out exactly what object self is? Otherwise, attach a log using papyon from git master with the attached patch applied.

Another thing: is this actually a bug, or are you just saying "I got a traceback"? By the looks of it, nothing bad is happening as a result of this? Perhaps apport is screaming in your face, but is there anything actually going wrong with butterfly?
Comment 9 Sense Hofstede 2010-03-14 11:01:33 UTC
Someone in the Ubuntu bug report provided an error log as well at <http://launchpadlibrarian.net/40927602/butterfly>.

The bug seems to be pretty easy to reproduce in Ubuntu Lucid, the crash appears at least a few times if Empathy is running.
Comment 10 Jonny Lamb 2010-04-09 06:09:16 UTC
(In reply to comment #9)
> Someone in the Ubuntu bug report provided an error log as well at
> <http://launchpadlibrarian.net/40927602/butterfly>.

This is a completely unrelated bug and has already been fixed.

On a more related note, I've got a branch to "fix" this bug. Check it out.
Comment 11 Olivier Le Thanh Duong 2010-04-13 06:25:38 UTC
(In reply to comment #10)
> (In reply to comment #9)
> > Someone in the Ubuntu bug report provided an error log as well at
> > <http://launchpadlibrarian.net/40927602/butterfly>.
> 
> This is a completely unrelated bug and has already been fixed.
> 
> On a more related note, I've got a branch to "fix" this bug. Check it out.

This just hide the bug to make apport happy, is there really a point to merge it upstream?
Comment 12 Jonny Lamb 2010-04-13 09:00:00 UTC
(In reply to comment #11)
> This just hide the bug to make apport happy, is there really a point to merge
> it upstream?

I didn't realise until recently that apport is told to be quiet in actual Ubuntu releases, so let's ignore this one.

NOTABUG
Comment 13 Jonny Lamb 2010-06-24 05:30:23 UTC
*** Bug 28190 has been marked as a duplicate of this bug. ***
Comment 14 Jonny Lamb 2010-06-24 05:30:35 UTC
*** Bug 28593 has been marked as a duplicate of this bug. ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.