Bug 17183 - pixman should use hidden attribute for private functions when compiling with Sun Studio
Summary: pixman should use hidden attribute for private functions when compiling with ...
Status: RESOLVED FIXED
Alias: None
Product: pixman
Classification: Unclassified
Component: pixman (show other bugs)
Version: 0.1.3
Hardware: Other Solaris
: medium normal
Assignee: Ginn Chen
QA Contact: Søren Sandmann Pedersen
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-18 00:51 UTC by Ginn Chen
Modified: 2008-08-21 14:21 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
patch (1.15 KB, patch)
2008-08-18 01:05 UTC, Ginn Chen 		Details | Splinter Review
View All

Description Ginn Chen 2008-08-18 00:51:27 UTC 
Now it only supports GCC 4.

It may cause problems if another program has a different version of pixman.
Comment 1 Ginn Chen 2008-08-18 01:05:03 UTC 
Created attachment 18351 [details] [review]
patch
Comment 2 Alan Coopersmith 2008-08-21 14:21:44 UTC 
I verified this patch and pushed it to git master:

commit 9b9f7b59e5ce17735157ca9b154e8bc545f5c96b
Author: Ginn Chen <ginn.chen@sun.com>
Date:   Thu Aug 21 14:21:01 2008 -0700

    Use hidden attribute for private functions when compiling with Sun Studio
    
    https://bugs.freedesktop.org/show_bug.cgi?id=17183
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.