Bug 1739 - xmodmap prints incorrect line numbers in error messages
Summary: xmodmap prints incorrect line numbers in error messages
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/xmodmap (show other bugs)
Version: git
Hardware: All All
: medium minor
Assignee: Alan Coopersmith
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-30 13:24 UTC by Alan Coopersmith
Modified: 2011-10-15 16:49 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Fix xmodmap line number output (written by Sam Lau of Sun X group) (1.14 KB, patch)
2004-10-30 13:28 UTC, Alan Coopersmith 		no flags Details | Splinter Review
View All

Description Alan Coopersmith 2004-10-30 13:24:33 UTC 
[Originally reported to Sun as Solaris bug id #4637857]

"xmodmap" prints line numbers which are one too low in error messages:
 
$ echo foo >bar
$ xmodmap bar
xmodmap:  unknown command on line bar:0
xmodmap:  1 error encountered, aborting.

It obviously starts line number with 0 internally but should start with 1.
Comment 1 Alan Coopersmith 2004-10-30 13:28:38 UTC 
Created attachment 1190 [details] [review]
Fix xmodmap line number output (written by Sam Lau of Sun X group)
Comment 2 Alan Coopersmith 2004-10-30 13:34:24 UTC 
Fix committed to Xorg head on 30-Oct-2004:
/cvs/xorg/xc/programs/xmodmap/handle.c,v  <--  handle.c
new revision: 1.3; previous revision: 1.2
/cvs/xorg/xc/programs/xmodmap/pf.c,v  <--  pf.c
new revision: 1.3; previous revision: 1.2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.