Bug 17753 - HAL lists "locale" mount option as available for ntfs
Summary: HAL lists "locale" mount option as available for ntfs
Status: RESOLVED FIXED
Alias: None
Product: hal
Classification: Unclassified
Component: spec (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: David Zeuthen (not reading bugmail)
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-24 07:29 UTC by Ambroz Bizjak
Modified: 2008-10-13 04:36 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
don't list the "locale" option (820 bytes, patch)
2008-09-24 07:29 UTC, Ambroz Bizjak
Details | Splinter Review

Description Ambroz Bizjak 2008-09-24 07:29:02 UTC
Created attachment 19152 [details] [review]
don't list the "locale" option

HAL lists "locale" as an available mount option for the "ntfs" filesystem type. However, the in-kernel ntfs driver in Linux does not really support this option. If the client mounting the device provides this option, the mount will fail (see "mount" man page).
The availability of this option is a mistake, because it IS supported by the ntfs-3g driver (and also the unmaintained and dysfunctional "ntfsmount"). However, these drivers install their own config file to HAL which changes the fstype to something else, so the correct driver is used, and also set the mount options they support in their own config file.
So, the option should be removed. Patch is attached.
Comment 1 Danny Kukawka 2008-10-13 04:36:50 UTC
fixed in git:

commit a0d82b80f775faf666aa699f354338098286ff20
Author: Danny Kukawka <danny.kukawka@web.de>
Date:   Thu Oct 9 13:54:26 2008 +0200

    Revert "allow 'locale=' NTFS mount option for Linux"

    This reverts commit a372bf79e16a5c6c00d0e262745dc935de364ca2.

    The ntfs-3g or ntfs-fuse package has to install their own fdi
    file to allow locale as mount option if needed. Otherwise HAL
    would allow invalid mount options for plain kernel ntfs.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.