Bug 17778 - Is TS_Raw defined with the correct values?
Summary: Is TS_Raw defined with the correct values?
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 7.4 (2008.09)
Hardware: All All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Depends on:
Reported: 2008-09-25 18:10 UTC by Kevin Day
Modified: 2018-12-13 22:20 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description Kevin Day 2008-09-25 18:10:53 UTC
TS_Raw and similar were removed from xinputproto at some point.
This later caused a problem.
This problem was fixed by having the TS_Raw and similar put back into the xorg server.

Namely: xorg-server 1.5.1/hw/xfree86/common/xf86Xinput.h
Lines: 88->90

/* Stupid API backwards-compatibility. */
#define TS_Raw 60
#define TS_Scaled 61

Are the values 60 & 61 correct?
Please defend/explain why they are 60 and 61.
Because when I look at: inputproto-1.3.2/XI.h
Lines: 207->212
where the TS_Raw values were originally defined as:

/* Merged from Metrolink tree for XINPUT stuff  */
#define TS_Raw                                  57
#define TS_Scaled                               58
#define SendCoreEvents                  59
#define DontSendCoreEvents              60
/* End of merged section        */

Here they are defined as 57 and 58.

I cannot see the new values as correct, especially when looking at the bottom of xorg-server-1.5.2's xf86Xinput.h on lines 211->213, the following exists:

/* Legacy hatred */
#define SendCoreEvents 59
#define DontSendCoreEvents 60

Notice that here, TS-Raw is defined as the same number as DontSendCoreEvents
Looking at the old XI.h, DontSendCoreEvents and TS_Raw are grouped together AND are different numbers.

This problem effects xorg-server 1.4.
As far as xorg-server 1.3, the TS_Raw is missing entirely and that was when the TS_Raw is missing problem was noticed.
See bug: 10262
Comment 1 Peter Hutterer 2008-09-29 00:38:09 UTC
AFAIU, TS_Raw should be removed from the server sources and the definition should be moved to the drivers that need it.

That aside, I agree that the value is wrong, but I'd like daniels' comment on that, maybe he remembers that change.
Comment 2 GitLab Migration User 2018-12-13 22:20:18 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/xserver/issues/373.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.