Bug 17789 - Avoid warnings when compiling for 64-bit Windows
Summary: Avoid warnings when compiling for 64-bit Windows
Status: RESOLVED FIXED
Alias: None
Product: pixman
Classification: Unclassified
Component: pixman (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Søren Sandmann Pedersen
QA Contact: Søren Sandmann Pedersen
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-26 04:36 UTC by Tor Lillqvist
Modified: 2012-11-17 00:40 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Suggested patch (18.62 KB, patch)
2008-09-26 04:36 UTC, Tor Lillqvist
Details | Splinter Review

Description Tor Lillqvist 2008-09-26 04:36:02 UTC
When compiling pixman for 64-bit Windows (where int and long are 32 still bits, pointers  and "long long" 64 bits) at least gcc 4.4 emits quite a lot of warnings because the code casts pointers to unsigned long. It's better to cast to uintptr_t instead. Unfortunately, not all platforms have <stdint.h>, for instance not even the latest MS Visial Studio. So some boring ifdefs are presumably required.

I will attach a patch, but it needs work at least because it has no ifdef logic to typedef uintptr_t for platforms that don't have it.
Comment 1 Tor Lillqvist 2008-09-26 04:36:34 UTC
Created attachment 19236 [details] [review]
Suggested patch
Comment 2 Søren Sandmann Pedersen 2012-11-17 00:40:29 UTC
Fixed in master.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.