Bug 17946 - patches to avoid gcc warnings for libX11
Summary: patches to avoid gcc warnings for libX11
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xlib (show other bugs)
Version: 7.3 (2007.09)
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: janitor, patch
Depends on:
Blocks:
 
Reported: 2008-10-07 08:27 UTC by Peter Breitenlohner
Modified: 2009-01-29 15:00 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
patch to avoid gcc warning for libX11 (V 1.1.5): redefined (1.80 KB, patch)
2008-10-07 08:27 UTC, Peter Breitenlohner 		no flags Details | Splinter Review
patch to avoid gcc warning for libX11 (V 1.1.5): missing newline (1.89 KB, patch)
2008-10-07 08:29 UTC, Peter Breitenlohner 		no flags Details | Splinter Review
patch to avoid gcc warning for libX11 (V 1.1.5): discards qualifiers (1.41 KB, patch)
2008-10-07 08:31 UTC, Peter Breitenlohner 		no flags Details | Splinter Review
patch to avoid gcc warning for libX11 (V 1.1.5): discards qualifiers (1008 bytes, patch)
2008-10-07 08:31 UTC, Peter Breitenlohner 		no flags Details | Splinter Review
patch to avoid gcc warning for libX11 (V 1.1.5): incompatible pointer type (761 bytes, patch)
2008-10-07 08:32 UTC, Peter Breitenlohner 		no flags Details | Splinter Review
View All

Description Peter Breitenlohner 2008-10-07 08:27:12 UTC 
Created attachment 19439 [details] [review]
patch to avoid gcc warning for libX11 (V 1.1.5): redefined

Attached are five small patches to avoid various gcc warnings for libX11 (V 1.1.5), each patch starting with a short comment

Some of the warnings actually point to the problem that two of the manpages are incomplete (probably truncated).
Comment 1 Peter Breitenlohner 2008-10-07 08:29:27 UTC 
Created attachment 19440 [details] [review]
patch to avoid gcc warning for libX11 (V 1.1.5): missing newline

Two of these warnings are actually due to truncated (or otherwise incomplete) manpages
Comment 2 Peter Breitenlohner 2008-10-07 08:31:11 UTC 
Created attachment 19441 [details] [review]
patch to avoid gcc warning for libX11 (V 1.1.5): discards qualifiers
Comment 3 Peter Breitenlohner 2008-10-07 08:31:42 UTC 
Created attachment 19442 [details] [review]
patch to avoid gcc warning for libX11 (V 1.1.5): discards qualifiers
Comment 4 Peter Breitenlohner 2008-10-07 08:32:32 UTC 
Created attachment 19443 [details] [review]
patch to avoid gcc warning for libX11 (V 1.1.5): incompatible pointer type
Comment 5 Paulo César Pereira de Andrade 2009-01-29 15:00:35 UTC 
Thanks for the patches.

Corrections just pushed to git master.

Attachment #19442 [details] was already applied (by me) on
another batch of bug fixes.

About the question in attachment #19443 [details] [review] (I am no
expert :-) but type Xim has the private field
(named "private" of type XIMPrivateRec, while XIM
doesn't.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.