I fixed that today, can you please fetch from git and try again?

Peter: thanks for the swift response! I don't suppose that comes down to a single commit does it? It would be by far easiest for me to test if I could quickly apply a patch to the package I have and rebuild it.
If not then nevermind, I'll grab the whole thing and build it :)

b0737bdbd1f6e601eb4984b6f4cb49279190984ca should have been it.

It'd be great if you could test git tip too though.

Created attachment 19651 [details] [review]
disables ABI checking for xinput

I'm not exactly sure if I'm doing the right things in testing this, but if I am, I don't think it's working.

I did:

git clone git://anongit.freedesktop.org/xorg/driver/xf86-input-evdev
git branch --track evdev-2.1-branch origin/evdev-2.1-branch
git checkout evdev-2.1-branch
applied ubuntu's ABI skipping patch (attached)
./autogen.sh --prefix=/usr
make
sudo make install

restarted X

I now see more xinput properties:


Device 'TPPS/2 IBM TrackPoint':
	Device Enabled:		1
	Evdev Axis Inversion:		0, 0
	Evdev Reopen Attempts:		10
	Evdev Middle Button Emulation:		0
	Evdev Middle Button Timeout:		50
	Evdev Wheel Emulation:		0
	Evdev Wheel Emulation Axes:		0, 0, 4, 5
	Evdev Wheel Emulation Inertia:		10
	Evdev Wheel Emulation Timeout:		200
	Evdev Wheel Emulation Button:		0
	Evdev Drag Lock Buttons:		0
	Wheel Emulation:		1
	Wheel Emulation Button:		2
	Wheel Emulation Y Axis:		4, 5

(not the default values, I played a little)

I see Wheel Emulation and Evdev Wheel Emulation, but enable either/both doesn't stop button 2 (middle) behaving purely as paste.

>         Evdev Wheel Emulation:          0
>         Evdev Wheel Emulation Button:           0

>         Wheel Emulation:                1
>         Wheel Emulation Button:         2
>         Wheel Emulation Y Axis:         4, 5

you created new properties with your command. the property names are all prefixed with "Evdev ". Try again with the right property name (or the number, that'll work too)

Sorry, I did try setting those too, but it doesn't seem to help...

Fresh start:

  Evdev Wheel Emulation:    0
  Evdev Wheel Emulation Axes:   0, 0, 4, 5
  Evdev Wheel Emulation Inertia:    10
  Evdev Wheel Emulation Timeout:    200
  Evdev Wheel Emulation Button:   4

xinput set-int-prop "TPPS/2 IBM TrackPoint" "Evdev Wheel Emulation Button" 8 2
xinput set-int-prop "TPPS/2 IBM TrackPoint" "Evdev Wheel Emulation" 8 1

  Evdev Wheel Emulation:    1
  Evdev Wheel Emulation Axes:   0, 0, 4, 5
  Evdev Wheel Emulation Inertia:    10
  Evdev Wheel Emulation Timeout:    200
  Evdev Wheel Emulation Button:   2

Middle button still acts as a pure middle button.

Created attachment 19654 [details]
Xorg log

wait, does it work at all? or just not after resume?

With the version currently shipping in Ubuntu Intrepid it works at first, but then stops after a suspend.

I've not been able to get the git version to work at all, but I should probably do a full reboot to be sure.

I had this same problem on Ubuntu 8.10. I just tried the latest git version and it did indeed fix the problem as far as I can tell. I'm going on about a dozen suspend-resume cycles and still no problems.

I had a peculiar problem once I installed the git version. Every time I hit Ctrl-C, the X-server would crash, and every time I hit Alt-F4, it would switch to a terminal.
I don't know if this is related but I thought I'd better let you know. The problem was resolved by reinstalling the Ubuntu version of evdev, which is from git on 2008-09-12.

Ok, so I used the b0737bdbd1f6e601eb4984b6f4cb49279190984c commit to patch the Ubuntu version, and it solved the scrolling problem I had with the Ubuntu version as well as the crashing problem I had with HEAD, but it appears that another bug was introduced. After a VT-switch I cannot drag things with the mouse, for instance drag a window or copy with the mouse. 
I'm guessing thats what draglock that was mentioned in the commit is for?

On Sat, Oct 25, 2008 at 08:30:15AM -0700, bugzilla-daemon@freedesktop.org wrote:
> Ok, so I used the b0737bdbd1f6e601eb4984b6f4cb49279190984c commit to patch the
> Ubuntu version, and it solved the scrolling problem I had with the Ubuntu
> version as well as the crashing problem I had with HEAD, but it appears that
> another bug was introduced. After a VT-switch I cannot drag things with the
> mouse, for instance drag a window or copy with the mouse. 
> I'm guessing thats what draglock that was mentioned in the commit is for?

no. draglock is a feature for those who can't hold a button down while
dragging. shouldn't affect standard mouse operation at all.
the problem is caused because the wakeup handlers didn't register again. Please
try the patch below, fixes the problem for me.


commit ea13733382f85dec6cadfb631831cfa6ed4bc69a
Author: Peter Hutterer <peter.hutterer@redhat.com>
Date:   Mon Oct 27 15:54:49 2008 +1030

    emuMB: add EvdevMBEmuOn and call from EvdevOn to register wakeup handlers.
    
    This got broken in b0737bdbd1f6e601eb4984b6f4cb49279190984c, when the
    EmuMBPreInit call was removed from EvdevOn. As a result, VT switching away and
    back wouldn't restore the wakeup handlers and mouse button presses
    disappeared.

diff --git a/src/emuMB.c b/src/emuMB.c
index 4af0791..e5a767a 100644
--- a/src/emuMB.c
+++ b/src/emuMB.c
@@ -317,6 +317,11 @@ EvdevMBEmuPreInit(InputInfoPtr pInfo)
 
     pEvdev->emulateMB.timeout = xf86SetIntOption(pInfo->options,
                                                  "Emulate3Timeout", 50);
+}
+
+void
+EvdevMBEmuOn(InputInfoPtr pInfo)
+{
     RegisterBlockAndWakeupHandlers (EvdevMBEmuBlockHandler,
                                     EvdevMBEmuWakeupHandler,
                                     (pointer)pInfo);
diff --git a/src/evdev.c b/src/evdev.c
index d112efe..26ae0a1 100644
--- a/src/evdev.c
+++ b/src/evdev.c
@@ -1008,6 +1008,7 @@ EvdevOn(DeviceIntPtr device)
     } else
     {
         xf86AddEnabledDevice(pInfo);
+        EvdevMBEmuOn(pInfo);
         pEvdev->flags |= EVDEV_INITIALIZED;
         device->public.on = TRUE;
     }
diff --git a/src/evdev.h b/src/evdev.h
index c2f614a..7e1da15 100644
--- a/src/evdev.h
+++ b/src/evdev.h
@@ -127,6 +127,7 @@ BOOL EvdevMBEmuFilterEvent(InputInfoPtr, int, BOOL);
 void EvdevMBEmuWakeupHandler(pointer, int, pointer);
 void EvdevMBEmuBlockHandler(pointer, struct timeval**, pointer);
 void EvdevMBEmuPreInit(InputInfoPtr);
+void EvdevMBEmuOn(InputInfoPtr);
 void EvdevMBEmuFinalize(InputInfoPtr);
 void EvdevMBEmuEnable(InputInfoPtr, BOOL);

Great thanks, that works perfectly.