Bug 1818 - xmodmap segfaults
Summary: xmodmap segfaults
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
: 1875 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-11-10 05:23 UTC by Giuseppe Ciotta
Modified: 2004-12-07 03:17 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
[FIXED_X11R68x] Patch for 6.8.2 to fix this and the original xmodmap overflow (3.47 KB, patch)
2004-11-11 07:42 UTC, Kristian Høgsberg
roland.mainz: 6.8-branch+
Details | Splinter Review

Description Giuseppe Ciotta 2004-11-10 05:23:42 UTC
xmodmap segfaults here parsing this line:
keycode 111 = Print
removing this line makes it work ok; works ok with XFree 4.3.0 xmodmap (it
assign the KeySym correctly).
Comment 1 rob mayoff 2004-11-10 14:56:51 UTC
See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=138743 for probable explanation.
Comment 2 Kristian Høgsberg 2004-11-11 07:42:14 UTC
Created attachment 1286 [details] [review]
[FIXED_X11R68x] Patch for 6.8.2 to fix this and the original xmodmap overflow

This is now fixed on HEAD.

Attaching patch to fix the original xmodmap overflow for 6.8.2:

      https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=83720
      https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=103161

including the fix for this bug.
Comment 3 Kristian Høgsberg 2004-11-11 07:43:16 UTC
Closing as fix has been committed to head.
Comment 4 Roland Mainz 2004-11-19 07:34:16 UTC
Comment on attachment 1286 [details] [review]
[FIXED_X11R68x] Patch for 6.8.2 to fix this and the original xmodmap overflow

Approved for the X11R6.8.x branch in the 2004-11-17 release-wranglers phone
call.
Please don't commit it yourself, I'll handle that once the CVS service is
available again.
Comment 5 Kristian Høgsberg 2004-11-23 19:05:59 UTC
*** Bug 1875 has been marked as a duplicate of this bug. ***
Comment 6 Roland Mainz 2004-12-07 22:17:38 UTC
Comment on attachment 1286 [details] [review]
[FIXED_X11R68x] Patch for 6.8.2 to fix this and the original xmodmap overflow

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.11; previous revision: 1.365.2.10
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/xmodmap/pf.c,v  <--  pf.c
new revision: 1.1.1.1.6.1; previous revision: 1.1.1.1
/cvs/xorg/xc/programs/xmodmap/xmodmap.c,v  <--	xmodmap.c
new revision: 1.2.4.1; previous revision: 1.2
/cvs/xorg/xc/programs/xmodmap/xmodmap.h,v  <--	xmodmap.h
new revision: 1.2.4.1; previous revision: 1.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.